Add a policy to allow NTP promotions & default apps to be disabled.

Add a policy to allow NTP promotions & default apps to be disabled.

The new tab page has several hard-coded apps and app promotions that
may not be appropriate/desired for enterprise users (e.g. Angry Birds).
This policy allows administrators to disable the promos.

BUG=92155
TEST=Added new unit test.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96541

[Patrick Dubroy, 2011-08-09 11:53:56]

mnissler: Policy bits
estade: Changes to apps_promo stuff
dpolukhin: FYI - I removed a TODO with your name on it, because web store promos
*are* supported on ChromeOS now.

[Patrick Dubroy, 2011-08-09 12:39:30]

Hmm, the app promo unit tests actually don't work on ChromeOS, so I disabled
them again.

I could have sworn that I've seen Angry Birds promos on ChromeOS, but now I
can't figure out how to get a promo to show up. estade or dpolukhin, any
insight?

[Evan Stade, 2011-08-09 19:54:55]

the promo is dynamic; it's downloaded from the web. There's a flag for forcing
the promo to appear, but it will be the default promo rather than angry birds.

lgtm

http://codereview.chromium.org/7528024/diff/5001/chrome/browser/extensions/ap...
File chrome/browser/extensions/apps_promo.cc (right):

http://codereview.chromium.org/7528024/diff/5001/chrome/browser/extensions/ap...
chrome/browser/extensions/apps_promo.cc:226: return true;
as long as you are changing the logic around, I think the clearest is:

if (!GetDefaultappsInstalled() || promo_counter > kDefaultAppsCounterMax)
  return installed_ids.empty();

[...]

return true;

[Mattias Nissler (ping if slow), 2011-08-10 08:59:10]

LGTM

[commit-bot: I haz the power, 2011-08-12 10:03:51]

Change committed as 96541