Issue 7528021: Fix to make the log more meaningful when a user script file of an extension cannot be located

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7528021: Fix to make the log more meaningful when a user script file of an extension cannot be located (Closed)

Created:
9 years, 4 months ago by hashimoto

Modified:
9 years, 4 months ago

Reviewers:
Nebojša Ćirić

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, mihaip+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fix to make the log more meaningful when a user script file of an extension cannot be located LoadScriptContent outputs meaningful log when |path| is empty BUG=None TEST=compiles successfully Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96115

Patch Set 1 #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
	M	chrome/browser/extensions/user_script_master.cc	View		1 chunk	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

hashimoto

9 years, 4 months ago (2011-08-10 02:16:43 UTC) #3

On 2011/08/09 15:46:47, Nebojša Ćirić wrote:
> LGTM

Thanks for your quick review!

Expand Messages | Collapse Messages