Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(764)

Issue 7528017: Add address line 2 as a distinguishing field for Autofill addresses (in WebUI list) (Closed)

Created:
9 years, 4 months ago by Ilya Sherman
Modified:
9 years, 4 months ago
CC:
chromium-reviews, GeorgeY
Visibility:
Public.

Description

Add address line 2 as a distinguishing field for Autofill addresses (in WebUI list) Every field present in the address editor should be included in the list of distinguishing fields to avoid empty profile labels. BUG=91722 TEST=unit_tests --gtest_filter=AutofillProfileTest.PreviewSummaryString Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96006

Patch Set 1 #

Patch Set 2 : Update test expectations #

Patch Set 3 : Fix a typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -7 lines) Patch
M chrome/browser/autofill/autofill_profile.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/autofill/autofill_profile_unittest.cc View 1 2 4 chunks +16 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Ilya Sherman
Please tick the commit queue check box if everything looks ok.
9 years, 4 months ago (2011-08-09 01:29:43 UTC) #1
dhollowa
Looks like unit tests are failing.
9 years, 4 months ago (2011-08-09 02:09:07 UTC) #2
Ilya Sherman
On 2011/08/09 02:09:07, dhollowa wrote: > Looks like unit tests are failing. Should be all ...
9 years, 4 months ago (2011-08-09 09:27:44 UTC) #3
dhollowa
On 2011/08/09 09:27:44, Ilya Sherman wrote: > On 2011/08/09 02:09:07, dhollowa wrote: > > Looks ...
9 years, 4 months ago (2011-08-09 15:14:34 UTC) #4
commit-bot: I haz the power
9 years, 4 months ago (2011-08-09 17:10:50 UTC) #5
Change committed as 96006

Powered by Google App Engine
This is Rietveld 408576698