linux: warn if we're not running with the SUID sandbox

linux: warn if we're not running with the SUID sandbox

This should help reduce confusion on when/whether a sandbox is running.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95912

[agl, 2011-08-08 23:49:39]

LGTM

[Lei Zhang, 2011-08-09 09:09:45]

http://codereview.chromium.org/7528013/diff/1/content/browser/zygote_host_lin...
File content/browser/zygote_host_linux.cc (right):

http://codereview.chromium.org/7528013/diff/1/content/browser/zygote_host_lin...
content/browser/zygote_host_linux.cc:134: LOG(FATAL) << "The SUID sandbox helper
binary was found, but is not "
This message isn't quite right with this CL. If |sandbox_binary_| is
non-existent, the stat() fails and we end up here.

[Evan Martin, 2011-08-09 15:25:38]

Hm, can you elaborate on what your setup is?  I thought I convinced myself
sandbox_binary_ is only non-empty in configurations where it should be an error
that it's non-existent.

[Lei Zhang, 2011-08-09 18:59:52]

On 2011/08/09 15:25:38, Evan Martin wrote:
> Hm, can you elaborate on what your setup is?  I thought I convinced myself
> sandbox_binary_ is only non-empty in configurations where it should be an
error
> that it's non-existent.

I have |sandbox_binary_| set to an non-existent location, and it aborted with
"The SUID sandbox helper binary was found, but is not configured correctly. ...
chmod ..." When I went to look for it to chown/chmod it, it wasn't there.

[Evan Martin, 2011-08-09 19:02:45]

What is the location?  How did it get set to that?

[Lei Zhang, 2011-08-09 19:25:57]

On 2011/08/09 19:02:45, Evan Martin wrote:
> What is the location?  How did it get set to that?

It's my own debug build. I set it to /ulg/home/thestig/chrome_sandbox and I move
there / out of the way to test the effect of sandboxing.

[Evan Martin, 2011-08-09 20:15:23]

On Tue, Aug 9, 2011 at 12:25 PM,  <thestig@chromium.org> wrote:
> On 2011/08/09 19:02:45, Evan Martin wrote:
>>
>> What is the location?  How did it get set to that?
>
> It's my own debug build. I set it to /ulg/home/thestig/chrome_sandbox and I
> move
> there / out of the way to test the effect of sandboxing.

Ah, hm, so you are specifically moving the binary around?
Maybe you could just do
export CHROME_DEVEL_SANDBOX=
before running rather than relocating the binary?