Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 7528011: A gyp file that generates a Visual studio solution for only chrome and its transitive dependencies. (Closed)

Created:
9 years, 4 months ago by apatrick_chromium
Modified:
9 years, 4 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

A gyp file that generates a Visual studio solution for only certain targets and their transitive dependencies. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96103

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M build/all.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A build/some.gyp View 1 2 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
darin (slow to review)
LGTM http://codereview.chromium.org/7528011/diff/1/chrome/only_chrome.gyp File chrome/only_chrome.gyp (right): http://codereview.chromium.org/7528011/diff/1/chrome/only_chrome.gyp#newcode11 chrome/only_chrome.gyp:11: ], maybe you could add some helpful comments ...
9 years, 4 months ago (2011-08-08 23:22:12 UTC) #1
apatrick_chromium
http://codereview.chromium.org/7528011/diff/1/chrome/only_chrome.gyp File chrome/only_chrome.gyp (right): http://codereview.chromium.org/7528011/diff/1/chrome/only_chrome.gyp#newcode11 chrome/only_chrome.gyp:11: ], I can do that. I was also thinking, ...
9 years, 4 months ago (2011-08-08 23:28:41 UTC) #2
darin (slow to review)
> I can do that. I was also thinking, to make it more general, name ...
9 years, 4 months ago (2011-08-08 23:52:33 UTC) #3
apatrick_chromium
PTAL
9 years, 4 months ago (2011-08-09 00:09:35 UTC) #4
darin (slow to review)
LGTM http://codereview.chromium.org/7528011/diff/2004/build/some.gyp File build/some.gyp (right): http://codereview.chromium.org/7528011/diff/2004/build/some.gyp#newcode15 build/some.gyp:15: # '../chrome/chrome.gyp:chrome', # Tip: Create a dummy CL ...
9 years, 4 months ago (2011-08-09 05:28:56 UTC) #5
commit-bot: I haz the power
9 years, 4 months ago (2011-08-10 00:11:19 UTC) #6
Change committed as 96103

Powered by Google App Engine
This is Rietveld 408576698