Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: net/udp/udp_socket_win.cc

Issue 7528010: Remove Purify and Quantify (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/udp/udp_socket_win.cc
===================================================================
--- net/udp/udp_socket_win.cc (revision 96101)
+++ net/udp/udp_socket_win.cc (working copy)
@@ -8,7 +8,6 @@
#include "base/eintr_wrapper.h"
#include "base/logging.h"
-#include "base/memory/memory_debug.h"
#include "base/message_loop.h"
#include "base/metrics/stats_counters.h"
#include "base/rand_util.h"
@@ -324,13 +323,6 @@
&recv_addr_len_, &read_overlapped_, NULL);
if (rv == 0) {
if (ResetEventIfSignaled(read_overlapped_.hEvent)) {
- // Because of how WSARecv fills memory when used asynchronously, Purify
- // isn't able to detect that it's been initialized, so it scans for 0xcd
- // in the buffer and reports UMRs (uninitialized memory reads) for those
- // individual bytes. We override that in PURIFY builds to avoid the
- // false error reports.
- // See bug 5297.
- base::MemoryDebug::MarkAsInitialized(read_buffer.buf, num);
if (!ProcessSuccessfulRead(num, address))
return ERR_FAILED;
return static_cast<int>(num);

Powered by Google App Engine
This is Rietveld 408576698