Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 7528010: Remove Purify and Quantify (Closed)

Created:
9 years, 4 months ago by jeanluc1
Modified:
9 years, 4 months ago
CC:
chromium-reviews, brettw-cc_chromium.org
Visibility:
Public.

Description

Remove Purify and Quantify.Doing so will reduce substantially the size of the project files. BUG=92102 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97156

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Total comments: 1

Patch Set 6 : '' #

Patch Set 7 : '' #

Patch Set 8 : '' #

Patch Set 9 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -534 lines) Patch
M base/base.gypi View 1 2 3 4 5 6 7 3 chunks +0 lines, -5 lines 0 comments Download
D base/memory/memory_debug.h View 1 2 3 4 5 6 7 1 chunk +0 lines, -48 lines 0 comments Download
D base/memory/memory_debug.cc View 1 2 3 4 5 6 7 1 chunk +0 lines, -54 lines 0 comments Download
M base/memory/singleton_unittest.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -2 lines 0 comments Download
M base/message_loop.cc View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -3 lines 0 comments Download
M base/metrics/field_trial_unittest.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M base/pickle.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
D base/third_party/purify/LICENSE View 1 2 3 4 5 6 7 1 chunk +0 lines, -2 lines 0 comments Download
D base/third_party/purify/README.chromium View 1 2 3 4 5 6 7 1 chunk +0 lines, -2 lines 0 comments Download
D base/third_party/purify/pure.h View 1 2 3 4 5 6 7 1 chunk +0 lines, -145 lines 0 comments Download
D base/third_party/purify/pure_api.c View 1 2 3 4 5 6 7 1 chunk +0 lines, -152 lines 0 comments Download
M base/timer_unittest.cc View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download
M build/common.gypi View 1 2 3 4 5 6 7 2 chunks +0 lines, -24 lines 0 comments Download
M build/release.gypi View 1 2 3 4 5 6 7 1 chunk +0 lines, -1 line 0 comments Download
M chrome/app/client_util.cc View 1 2 3 4 5 6 7 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_context_menu_controller_unittest.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/bookmarks/recently_used_folders_combo_model_unittest.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/network_stats_unittest.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_service_test_util.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_context_menu_test.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/test/net/fake_external_tab.cc View 1 2 3 4 5 6 7 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/renderer_host/resource_dispatcher_host_unittest.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M content/browser/resolve_proxy_msg_helper_unittest.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M crypto/signature_verifier_unittest.cc View 1 2 3 4 5 6 7 2 chunks +0 lines, -9 lines 0 comments Download
M media/base/pipeline_impl_unittest.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M net/disk_cache/backend_unittest.cc View 1 2 3 4 5 6 7 1 chunk +2 lines, -3 lines 0 comments Download
M net/socket/tcp_client_socket_win.cc View 1 2 3 4 5 6 7 2 chunks +0 lines, -8 lines 0 comments Download
M net/udp/udp_socket_win.cc View 1 2 3 4 5 6 7 2 chunks +0 lines, -8 lines 0 comments Download
M tools/heapcheck/heapcheck_test.py View 1 2 3 4 5 6 7 1 chunk +1 line, -2 lines 0 comments Download
M views/focus/accelerator_handler_gtk_unittest.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M views/focus/focus_manager_unittest.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M webkit/extensions/v8/profiler_extension.cc View 1 2 3 4 5 6 7 5 chunks +2 lines, -22 lines 0 comments Download
M webkit/tools/test_shell/run_all_tests.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/test_shell_mac.mm View 1 2 3 4 5 6 7 1 chunk +0 lines, -1 line 0 comments Download
M webkit/tools/test_shell/test_shell_main.cc View 1 2 3 4 5 6 7 2 chunks +0 lines, -7 lines 0 comments Download
M webkit/tools/test_shell/test_shell_platform_delegate.h View 1 2 3 4 5 6 7 1 chunk +0 lines, -4 lines 0 comments Download
M webkit/tools/test_shell/test_shell_switches.h View 1 2 3 4 5 6 7 1 chunk +0 lines, -1 line 0 comments Download
M webkit/tools/test_shell/test_shell_switches.cc View 1 2 3 4 5 6 7 1 chunk +0 lines, -4 lines 0 comments Download
M webkit/tools/test_shell/test_shell_win.cc View 1 2 3 4 5 6 7 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jeanluc1
Here's the first pass removing everything related to Purify. There are more files that mention ...
9 years, 4 months ago (2011-08-10 01:06:34 UTC) #1
jam
lgtm, also adding Erik in case he has any comments http://codereview.chromium.org/7528010/diff/13009/base/message_loop.cc File base/message_loop.cc (right): http://codereview.chromium.org/7528010/diff/13009/base/message_loop.cc#newcode533 ...
9 years, 4 months ago (2011-08-10 02:55:27 UTC) #2
jeanluc1
William, I will need approval for the changes in net/*, base/*, and chrome/browser/net/* Wan-Teh, same ...
9 years, 4 months ago (2011-08-17 01:07:33 UTC) #3
willchan no longer on Chromium
LGTM
9 years, 4 months ago (2011-08-17 01:12:28 UTC) #4
wtc
9 years, 4 months ago (2011-08-17 01:23:47 UTC) #5 
LGTM on crypto/signature_verifier_unittest.cc.

Powered by Google App Engine
This is Rietveld 408576698