Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Issue 7528009: This is the exact same CL as in http://codereview.chromium.org/7570001 . (Closed)

Created:
9 years, 4 months ago by varunjain
Modified:
9 years, 4 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, jam, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

This is the exact same CL as in http://codereview.chromium.org/7570001 . That CL was revert due to build breakage. The cause of build break should be fixed in http://codereview.chromium.org/7529031/ BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95934

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -18 lines) Patch
M chrome/browser/renderer_host/render_widget_host_view_gtk.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_gtk.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_mac.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_mac.mm View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_views.h View 5 chunks +19 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_views.cc View 3 chunks +36 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_view_host.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view.h View 1 chunk +6 lines, -2 lines 0 comments Download
M content/common/view_messages.h View 2 chunks +9 lines, -2 lines 0 comments Download
M content/renderer/render_view.h View 2 chunks +5 lines, -0 lines 0 comments Download
M content/renderer/render_view.cc View 5 chunks +30 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
varunjain
9 years, 4 months ago (2011-08-08 22:02:29 UTC) #1
sky
Rubber stamp LGTM Feel free to TBR these sort of changes in the future.
9 years, 4 months ago (2011-08-08 22:13:52 UTC) #2
commit-bot: I haz the power
Presubmit check for 7528009-1 failed and returned exit status 1. Running presubmit commit checks ...
9 years, 4 months ago (2011-08-08 22:16:50 UTC) #3
darin (slow to review)
LGTM
9 years, 4 months ago (2011-08-08 22:46:09 UTC) #4
commit-bot: I haz the power
9 years, 4 months ago (2011-08-09 02:22:11 UTC) #5
Change committed as 95934

Powered by Google App Engine
This is Rietveld 408576698