[Mac] Delete more bookmark bar folder code. This removes things that were missed last time.

[Mac] Delete more bookmark bar folder code. This removes things that were missed last time.

One of the issues is that a nested event loop in |-mouseDown:| was causing the
thread to block after the menu closes, because the opening of the menu pumps the
mouseUp event.

BUG=91850
TEST=Open a bookmark from the folder and the spinner spins.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95901

[mrossetti, 2011-08-08 21:42:24]

LGTM

http://codereview.chromium.org/7528007/diff/2001/chrome/browser/ui/cocoa/book...
File chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm (right):

http://codereview.chromium.org/7528007/diff/2001/chrome/browser/ui/cocoa/book...
chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm:289: -
(BOOL)canBecomeKeyView {
Does the default implementation already return NO? If so, this function could
just be removed.

[Robert Sesek, 2011-08-08 21:42:48]

http://codereview.chromium.org/7528007/diff/2001/chrome/browser/ui/cocoa/book...
File chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm (right):

http://codereview.chromium.org/7528007/diff/2001/chrome/browser/ui/cocoa/book...
chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm:289: -
(BOOL)canBecomeKeyView {
On 2011/08/08 21:42:24, mrossetti wrote:
> Does the default implementation already return NO? If so, this function could
> just be removed.

I *think* it does, but it's not documented as such.