C++ wrappers for PPB_VideoCapture_Dev

C++ wrappers for PPB_VideoCapture_Dev

BUG=None
TEST=VideoCapture sample (in a later CL)

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95942

[brettw, 2011-08-08 22:46:31]

LGTM

http://codereview.chromium.org/7528006/diff/1/ppapi/cpp/dev/video_capture_cli...
File ppapi/cpp/dev/video_capture_client_dev.cc (right):

http://codereview.chromium.org/7528006/diff/1/ppapi/cpp/dev/video_capture_cli...
ppapi/cpp/dev/video_capture_client_dev.cc:23:
Instance::GetPerInstanceObject(instance, kPPPVideoCaptureInterface));
I'd normally expect client to be checked right after it's retrieved rather than
doing a bunch of stuff and then checking it later. So I'd probably early return
on !client.

http://codereview.chromium.org/7528006/diff/1/ppapi/cpp/dev/video_capture_cli...
ppapi/cpp/dev/video_capture_client_dev.cc:27: for (uint32_t i = 0;
i<buffer_count; ++i)
Style nit: spaces around <

[piman, 2011-08-09 02:44:36]

http://codereview.chromium.org/7528006/diff/1/ppapi/cpp/dev/video_capture_cli...
File ppapi/cpp/dev/video_capture_client_dev.cc (right):

http://codereview.chromium.org/7528006/diff/1/ppapi/cpp/dev/video_capture_cli...
ppapi/cpp/dev/video_capture_client_dev.cc:23:
Instance::GetPerInstanceObject(instance, kPPPVideoCaptureInterface));
On 2011/08/08 22:46:31, brettw wrote:
> I'd normally expect client to be checked right after it's retrieved rather
than
> doing a bunch of stuff and then checking it later. So I'd probably early
return
> on !client.

Done.

http://codereview.chromium.org/7528006/diff/1/ppapi/cpp/dev/video_capture_cli...
ppapi/cpp/dev/video_capture_client_dev.cc:27: for (uint32_t i = 0;
i<buffer_count; ++i)
On 2011/08/08 22:46:31, brettw wrote:
> Style nit: spaces around <

Done.