Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 7528003: CrOS - Fix flaky FileManagerDialogTest (Closed)

Created:
9 years, 4 months ago by James Cook
Modified:
9 years, 4 months ago
Reviewers:
rginda
CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews), achuith+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

CrOS - Fix flaky FileManagerDialogTest We were not waiting for the file manager extension to initialize its Web Worker process before starting the test, which lead to occasional crashes if the test completed before the init was done. BUG=chromium:89733 TEST=browser_tests --gtest_filter=FileManagerDialogTest.* --gtest_repeat=10 --gtest_shuffle Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95875

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rename message to worker-initialized #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -21 lines) Patch
M chrome/browser/resources/file_manager/js/file_manager.js View 1 2 2 chunks +12 lines, -1 line 0 comments Download
M chrome/browser/resources/file_manager/js/main.js View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/resources/file_manager/js/metadata_dispatcher.js View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/ui/views/file_manager_dialog_browsertest.cc View 1 2 7 chunks +26 lines, -15 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
James Cook
Robert, PTAL. I left the call to postMessage('initialized', [regex]) instead of converting to an object ...
9 years, 4 months ago (2011-08-08 18:28:11 UTC) #1
James Cook
On 2011/08/08 18:28:11, James Cook (Chromium) wrote: > Robert, PTAL. I left the call to ...
9 years, 4 months ago (2011-08-08 19:17:35 UTC) #2
rginda
9 years, 4 months ago (2011-08-08 19:18:45 UTC) #3
LGTM

On 2011/08/08 19:17:35, James Cook (Chromium) wrote:
> On 2011/08/08 18:28:11, James Cook (Chromium) wrote:
> > Robert, PTAL.  I left the call to postMessage('initialized', [regex])
instead
> of
> > converting to an object because we can just add more items to that array in
> the
> > future and they get mapped nicely to function arguments in file_manager.js. 
> It
> > seemed like what we did elsewhere.
> 
> I renamed the message to "worker-initialized" as we discussed.  How's it look
> now?

Powered by Google App Engine
This is Rietveld 408576698