Issue 7528: [chromium-reviews] Fix another crasher in Spell Checker related to file IO.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7528: [chromium-reviews] Fix another crasher in Spell Checker related to file IO. (Closed)

Created:
12 years, 2 months ago by sidchat (Google)

Modified:
9 years, 7 months ago

Reviewers:
brettw, Peter Kasting

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix another crasher in Spell Checker related to file IO. Issue=3039 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=3659

Patch Set 2 : '' #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	base/file_util.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Peter Kasting

http://codereview.chromium.org/7528/diff/1/2 File chrome/browser/spellchecker.cc (right): http://codereview.chromium.org/7528/diff/1/2#newcode515 Line 515: file_util::CloseFile(f); While this change seems fine, it might ...

12 years, 2 months ago (2008-10-21 04:54:39 UTC) #2

Expand Messages | Collapse Messages

Issue 7528: [chromium-reviews] Fix another crasher in Spell Checker related to file IO. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages