Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 7524032: Added support for Decode() calls during Reset(). (Closed)

Created:
9 years, 4 months ago by Ami GONE FROM CHROMIUM
Modified:
9 years, 4 months ago
CC:
chromium-reviews, hclam+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, jam, Paweł Hajdan Jr., acolwell+watch_chromium.org, annacc+watch_chromium.org, apatrick_chromium, joi+watch-content_chromium.org, ajwong+watch_chromium.org, vrk (LEFT CHROMIUM), scherkus (not reviewing), piman, cfreeman, vjain, vhiremath
Visibility:
Public.

Description

Added support for Decode() calls during Reset(). Decode() calls are now queued for later processing when the decoder is in RESETTING state. Also output buffers are queued by OVDA during the Flush() triggered by Reset() for re-use as soon as the Reset is done. BUG=none TEST=ovdatest, gles2, trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=94700

Patch Set 1 #

Total comments: 4

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -40 lines) Patch
M content/common/gpu/media/omx_video_decode_accelerator.h View 1 1 chunk +12 lines, -0 lines 0 comments Download
M content/common/gpu/media/omx_video_decode_accelerator.cc View 4 chunks +29 lines, -6 lines 0 comments Download
M content/common/gpu/media/omx_video_decode_accelerator_unittest.cc View 1 12 chunks +87 lines, -31 lines 0 comments Download
M media/base/bitstream_buffer.h View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Ami GONE FROM CHROMIUM
vrk: please review piman: FYI since you were in on related email threads
9 years, 4 months ago (2011-07-28 18:43:57 UTC) #1
vrk (LEFT CHROMIUM)
LGTM As we talked about in person, the OMX unit test is teetering on the ...
9 years, 4 months ago (2011-07-29 17:06:44 UTC) #2
Ami GONE FROM CHROMIUM
9 years, 4 months ago (2011-07-29 17:17:09 UTC) #3
Thanks.

http://codereview.chromium.org/7524032/diff/1/content/common/gpu/media/omx_vi...
File content/common/gpu/media/omx_video_decode_accelerator.h (right):

http://codereview.chromium.org/7524032/diff/1/content/common/gpu/media/omx_vi...
content/common/gpu/media/omx_video_decode_accelerator.h:183: std::vector<int>
queued_picture_buffer_ids_;
On 2011/07/29 17:06:44, Victoria Kirst wrote:
> nit: Add comment to explain queued picture buffers too (or elaborate on above
> comment)

Done.

http://codereview.chromium.org/7524032/diff/1/content/common/gpu/media/omx_vi...
File content/common/gpu/media/omx_video_decode_accelerator_unittest.cc (right):

http://codereview.chromium.org/7524032/diff/1/content/common/gpu/media/omx_vi...
content/common/gpu/media/omx_video_decode_accelerator_unittest.cc:624:
encoded_data_next_pos_to_decode_ = 0;
On 2011/07/29 17:06:44, Victoria Kirst wrote:
> Comment that we start playback over from the beginning on midstream reset?

Done.

Powered by Google App Engine
This is Rietveld 408576698