Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2986)

Unified Diff: chrome/browser/chromeos/cros/screen_lock_library.cc

Issue 7524014: cros: Remove the unneed default ctor from ScreenLockLibrary interface. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix mock Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/cros/screen_lock_library.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/cros/screen_lock_library.cc
diff --git a/chrome/browser/chromeos/cros/screen_lock_library.cc b/chrome/browser/chromeos/cros/screen_lock_library.cc
index a63f11a9e93a22035034fb29ebed7b0c20564c85..7dab51f672fa69b8b1b59a43cbbe7edd7a0f5567 100644
--- a/chrome/browser/chromeos/cros/screen_lock_library.cc
+++ b/chrome/browser/chromeos/cros/screen_lock_library.cc
@@ -1,28 +1,32 @@
-// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/chromeos/cros/screen_lock_library.h"
+#include "base/basictypes.h"
+#include "base/logging.h"
#include "base/message_loop.h"
-#include "base/string_util.h"
+#include "base/observer_list.h"
#include "chrome/browser/chromeos/cros/cros_library.h"
#include "content/browser/browser_thread.h"
+#include "third_party/cros/chromeos_screen_lock.h"
namespace chromeos {
-// This class handles the interaction with the ChromeOS screen lock APIs.
class ScreenLockLibraryImpl : public ScreenLockLibrary {
public:
- ScreenLockLibraryImpl() {
- if (CrosLibrary::Get()->EnsureLoaded()) {
- Init();
- }
- }
+ ScreenLockLibraryImpl() {}
~ScreenLockLibraryImpl() {
- if (screen_lock_connection_) {
+ if (screen_lock_connection_)
chromeos::DisconnectScreenLock(screen_lock_connection_);
+ }
+
+ void Init() {
+ if (CrosLibrary::Get()->EnsureLoaded()) {
+ screen_lock_connection_ =
+ chromeos::MonitorScreenLock(&ScreenLockedHandler, this);
}
}
@@ -51,9 +55,22 @@ class ScreenLockLibraryImpl : public ScreenLockLibrary {
}
private:
- void Init() {
- screen_lock_connection_ = chromeos::MonitorScreenLock(
- &ScreenLockedHandler, this);
+ static void ScreenLockedHandler(void* object, ScreenLockEvent event) {
+ ScreenLockLibraryImpl* self = static_cast<ScreenLockLibraryImpl*>(object);
+ switch (event) {
+ case chromeos::LockScreen:
+ self->LockScreen();
+ break;
+ case chromeos::UnlockScreen:
+ self->UnlockScreen();
+ break;
+ case chromeos::UnlockScreenFailed:
+ self->UnlockScreenFailed();
+ break;
+ default:
+ NOTREACHED();
+ break;
+ }
}
void LockScreen() {
@@ -89,26 +106,9 @@ class ScreenLockLibraryImpl : public ScreenLockLibrary {
FOR_EACH_OBSERVER(Observer, observers_, UnlockScreenFailed(this));
}
- static void ScreenLockedHandler(void* object, ScreenLockEvent event) {
- ScreenLockLibraryImpl* self = static_cast<ScreenLockLibraryImpl*>(object);
- switch (event) {
- case chromeos::LockScreen:
- self->LockScreen();
- break;
- case chromeos::UnlockScreen:
- self->UnlockScreen();
- break;
- case chromeos::UnlockScreenFailed:
- self->UnlockScreenFailed();
- break;
- default:
- NOTREACHED();
- }
- }
-
ObserverList<Observer> observers_;
- // A reference to the screen lock api
+ // A reference to the screen lock API.
chromeos::ScreenLockConnection screen_lock_connection_;
DISALLOW_COPY_AND_ASSIGN(ScreenLockLibraryImpl);
@@ -118,6 +118,7 @@ class ScreenLockLibraryStubImpl : public ScreenLockLibrary {
public:
ScreenLockLibraryStubImpl() {}
~ScreenLockLibraryStubImpl() {}
+ void Init() {}
void AddObserver(Observer* observer) {}
void RemoveObserver(Observer* observer) {}
void NotifyScreenLockRequested() {}
@@ -128,10 +129,13 @@ class ScreenLockLibraryStubImpl : public ScreenLockLibrary {
// static
ScreenLockLibrary* ScreenLockLibrary::GetImpl(bool stub) {
+ ScreenLockLibrary* impl;
if (stub)
- return new ScreenLockLibraryStubImpl();
+ impl = new ScreenLockLibraryStubImpl();
else
- return new ScreenLockLibraryImpl();
+ impl = new ScreenLockLibraryImpl();
+ impl->Init();
+ return impl;
}
} // namespace chromeos
« no previous file with comments | « chrome/browser/chromeos/cros/screen_lock_library.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698