Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2228)

Unified Diff: chrome/test/automation/proxy_launcher.h

Issue 7523060: Let pyauto create an attached webdriver instance to manipulate web pages. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ... Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/automation/proxy_launcher.h
diff --git a/chrome/test/automation/proxy_launcher.h b/chrome/test/automation/proxy_launcher.h
index 811366ba80c23e6b490c2222165a411e473d105c..0863c6cc5fc529ddbe5cf0ed922b992dd9c581c4 100644
--- a/chrome/test/automation/proxy_launcher.h
+++ b/chrome/test/automation/proxy_launcher.h
@@ -288,8 +288,11 @@ class NamedProxyLauncher : public ProxyLauncher {
public:
// If launch_browser is true, launches Chrome with named interface enabled.
// Otherwise, there should be an existing instance the proxy can connect to.
+ // wait_for_server_channel should be set to false only if it is guaranteed
+ // Chrome's server channel is already listening for connections.
NamedProxyLauncher(const std::string& channel_id,
bool launch_browser,
+ bool wait_for_server_channel,
Paweł Hajdan Jr. 2011/07/29 20:48:38 3 bool parameters next to each other are a recipe
kkania 2011/07/29 22:44:19 Changed to struct. We know the channel is ready b
bool disconnect_on_failure);
virtual AutomationProxy* CreateAutomationProxy(
@@ -301,9 +304,10 @@ class NamedProxyLauncher : public ProxyLauncher {
virtual std::string PrefixedChannelID() const OVERRIDE;
protected:
- std::string channel_id_; // Channel id of automation proxy.
- bool launch_browser_; // True if we should launch the browser too.
- bool disconnect_on_failure_; // True if we disconnect on IPC channel failure.
+ std::string channel_id_; // Channel id of automation proxy.
+ bool launch_browser_; // True if we should launch the browser too.
+ bool wait_for_server_channel_; // True if we should wait for server channel.
+ bool disconnect_on_failure_; // True if we disconnect on channel failure.
private:
DISALLOW_COPY_AND_ASSIGN(NamedProxyLauncher);

Powered by Google App Engine
This is Rietveld 408576698