Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Unified Diff: chrome/browser/automation/automation_provider.cc

Issue 7523060: Let pyauto create an attached webdriver instance to manipulate web pages. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: address nirnimesh' latest comments Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/automation/testing_automation_provider.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/automation/automation_provider.cc
diff --git a/chrome/browser/automation/automation_provider.cc b/chrome/browser/automation/automation_provider.cc
index 1e25d61403b85241aa0617c64ebf011f19276364..0b01a1472c2eb2022f10a2e40d4846528337fe57 100644
--- a/chrome/browser/automation/automation_provider.cc
+++ b/chrome/browser/automation/automation_provider.cc
@@ -156,6 +156,7 @@ bool AutomationProvider::InitializeChannel(const std::string& channel_id) {
automation_resource_message_filter_ = new AutomationResourceMessageFilter;
}
+ base::ThreadRestrictions::ScopedAllowIO allow_io;
Paweł Hajdan Jr. 2011/08/02 23:31:24 My NAK on this still holds.
kkania 2011/08/03 17:38:00 Fixing this problem will require some significant
Paweł Hajdan Jr. 2011/08/03 19:09:16 Then please do those changes. What is so hard abou
channel_.reset(new IPC::ChannelProxy(
effective_channel_id,
GetChannelMode(use_named_interface),
@@ -421,8 +422,6 @@ void AutomationProvider::HandleUnused(const IPC::Message& message, int handle) {
}
bool AutomationProvider::ReinitializeChannel() {
- base::ThreadRestrictions::ScopedAllowIO allow_io;
-
// Make sure any old channels are cleaned up before starting up a new one.
channel_.reset();
return InitializeChannel(channel_id_);
« no previous file with comments | « no previous file | chrome/browser/automation/testing_automation_provider.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698