String to ascii char array converter for debug mode.

src/objects-printer.cc

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 542 matching lines @@
     PrintF(out, "%c", Get(i));
   }
   if (len != length()) {
     PrintF(out, "%s", truncated_epilogue);
   }
 
   if (!StringShape(this).IsSymbol()) PrintF(out, "\"");
 }
 
 
+char* String::ToAsciiArray() {
+  static char* buffer = NULL;

[Sven Panne, 2011/07/29 09:31:46]

Drive-by commment: This looks scary... The real problem is that we mix 2 things
here (like in lots of other places): Memory management and the conversion
itself. This leads to obscure ownerships and lifetimes, like the "static" above.
IMHO it would be cleaner and simpler to transfer the ownership of the result to
the caller.

Long-term solution: Switch to C++-style << and >>, one rarely needs the whole
converted result/input all at once.

+  if (buffer != NULL)

[Rico, 2011/07/29 09:18:07]

{ } around if body unless moved to same line

+    free(buffer);
+  buffer = new char[length()+1];
+  WriteToFlat(this, buffer, 0, length());
+  buffer[length()] = 0;
+  return buffer;
+}
+
+
 void JSProxy::JSProxyPrint(FILE* out) {
   HeapObject::PrintHeader(out, "JSProxy");
   PrintF(out, " - map = 0x%p\n", reinterpret_cast<void*>(map()));
   PrintF(out, " - handler = ");
   handler()->Print(out);
   PrintF(out, "\n");
 }
 
 
 void JSFunction::JSFunctionPrint(FILE* out) {
@@ skipping 273 matching lines @@
     desc.Print(out);
   }
   PrintF(out, "\n");
 }
 
 
 #endif  // OBJECT_PRINT
 
 
 } }  // namespace v8::internal