Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 7523024: Merge 91803 - Float32Array(ArrayBuffer, index, length) constructor working incorrectly. (Closed)

Created:
9 years, 5 months ago by Ken Russell (switch to Gerrit)
Modified:
9 years, 5 months ago
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/835/
Visibility:
Public.

Description

Merge 91803 - Float32Array(ArrayBuffer, index, length) constructor working incorrectly. https://bugs.webkit.org/show_bug.cgi?id=57042 Reviewed by James Robinson. Source/WebCore: * bindings/js/JSArrayBufferViewHelper.h: (WebCore::constructArrayBufferViewWithArrayBufferArgument): * bindings/v8/custom/V8ArrayBufferViewCustom.h: (WebCore::constructWebGLArrayWithArrayBufferArgument): LayoutTests: * fast/canvas/webgl/array-unit-tests-expected.txt: * fast/canvas/webgl/array-unit-tests.html: TBR=kbr@google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91889

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -16 lines) Patch
M LayoutTests/fast/canvas/webgl/array-unit-tests.html View 3 chunks +21 lines, -1 line 0 comments Download
M LayoutTests/fast/canvas/webgl/array-unit-tests-expected.txt View 14 chunks +22 lines, -8 lines 0 comments Download
M Source/WebCore/bindings/js/JSArrayBufferViewHelper.h View 1 chunk +8 lines, -3 lines 0 comments Download
M Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.h View 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Ken Russell (switch to Gerrit)
9 years, 5 months ago (2011-07-28 01:27:03 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698