Issue 7523024: Merge 91803 - Float32Array(ArrayBuffer, index, length) constructor working incorrectly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7523024: Merge 91803 - Float32Array(ArrayBuffer, index, length) constructor working incorrectly. (Closed)

Created:
9 years, 5 months ago by Ken Russell (switch to Gerrit)

Modified:
9 years, 5 months ago

Reviewers:
Ken Russell (switch to Gerrit)

CC:
chromium-reviews

Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/835/

Visibility:
Public.

Description

Merge 91803 - Float32Array(ArrayBuffer, index, length) constructor working incorrectly. https://bugs.webkit.org/show_bug.cgi?id=57042 Reviewed by James Robinson. Source/WebCore: * bindings/js/JSArrayBufferViewHelper.h: (WebCore::constructArrayBufferViewWithArrayBufferArgument): * bindings/v8/custom/V8ArrayBufferViewCustom.h: (WebCore::constructWebGLArrayWithArrayBufferArgument): LayoutTests: * fast/canvas/webgl/array-unit-tests-expected.txt: * fast/canvas/webgl/array-unit-tests.html: TBR=kbr@google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91889

Patch Set 1 #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+56 lines, -16 lines)			Patch
M	LayoutTests/fast/canvas/webgl/array-unit-tests.html	View	3 chunks	+21 lines, -1 line	0 comments	Download
M	LayoutTests/fast/canvas/webgl/array-unit-tests-expected.txt	View	14 chunks	+22 lines, -8 lines	0 comments	Download
M	Source/WebCore/bindings/js/JSArrayBufferViewHelper.h	View	1 chunk	+8 lines, -3 lines	0 comments	Download
M	Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.h	View	1 chunk	+5 lines, -4 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages