Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Unified Diff: content/browser/gpu/gpu_blacklist.cc

Issue 7523019: Include accelerated_compositing disable flag in about:gpu status (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Tweak messages care of kbr ideas Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/gpu_internals/info_view.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/gpu/gpu_blacklist.cc
diff --git a/content/browser/gpu/gpu_blacklist.cc b/content/browser/gpu/gpu_blacklist.cc
index f0c4413a7670ed7ad10b9073eaa10991c0446724..255ab4bea3f3af09811e7f1e6fc8d82367eba630 100644
--- a/content/browser/gpu/gpu_blacklist.cc
+++ b/content/browser/gpu/gpu_blacklist.cc
@@ -746,6 +746,9 @@ Value* GpuBlacklist::GetFeatureStatus(bool gpu_access_allowed,
GpuFeatureFlags::kGpuFeatureAccelerated2dCanvas))
feature_status_list->Append(NewStatusValue("2d_canvas",
"unavailable_software"));
+ else if (disable_accelerated_compositing)
+ feature_status_list->Append(NewStatusValue("2d_canvas",
+ "disabled_software"));
else
feature_status_list->Append(NewStatusValue("2d_canvas",
"enabled"));
@@ -789,6 +792,9 @@ Value* GpuBlacklist::GetFeatureStatus(bool gpu_access_allowed,
GpuFeatureFlags::kGpuFeatureWebgl))
feature_status_list->Append(NewStatusValue("webgl",
"unavailable_off"));
+ else if (disable_accelerated_compositing)
+ feature_status_list->Append(NewStatusValue("webgl",
+ "enabled_readback"));
else
feature_status_list->Append(NewStatusValue("webgl",
"enabled"));
@@ -834,7 +840,8 @@ Value* GpuBlacklist::GetFeatureStatus(bool gpu_access_allowed,
DictionaryValue* problem = new DictionaryValue();
problem->SetString("description",
"Accelerated compositing has been disabled, either via about:flags "
- "or command line");
+ "or command line. This adversely affects performance of all hardware "
+ " accelerated features.");
problem->Set("crBugs", new ListValue());
problem->Set("webkitBugs", new ListValue());
problem_list->Append(problem);
« no previous file with comments | « chrome/browser/resources/gpu_internals/info_view.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698