Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Issue 7523019: Include accelerated_compositing disable flag in about:gpu status (Closed)

Created:
9 years, 4 months ago by nduca
Modified:
9 years, 4 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, arv (Not doing code reviews), jam, apatrick_chromium
Visibility:
Public.

Description

Include accelerated_compositing disable flag in calculation of about:gpu feature status. BUG=90723 TEST=Run chrome with --disable-accelerated-compositing, verify about:gpu status is expected Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95046

Patch Set 1 #

Total comments: 3

Patch Set 2 : Tweak messages care of kbr ideas #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M chrome/browser/resources/gpu_internals/info_view.js View 1 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/gpu/gpu_blacklist.cc View 1 3 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
nduca
Quick fix. I know there was discussion about refactoring this getstate method into gpu_data_manager. I ...
9 years, 4 months ago (2011-07-28 00:09:13 UTC) #1
Zhenyao Mo
On 2011/07/28 00:09:13, nduca wrote: > Quick fix. > > I know there was discussion ...
9 years, 4 months ago (2011-07-28 20:38:25 UTC) #2
nduca
+kbr for OWNERS
9 years, 4 months ago (2011-07-28 20:40:10 UTC) #3
Ken Russell (switch to Gerrit)
http://codereview.chromium.org/7523019/diff/1/content/browser/gpu/gpu_blacklist.cc File content/browser/gpu/gpu_blacklist.cc (right): http://codereview.chromium.org/7523019/diff/1/content/browser/gpu/gpu_blacklist.cc#newcode795 content/browser/gpu/gpu_blacklist.cc:795: else if (disable_accelerated_compositing) I'm not sure this is correct. ...
9 years, 4 months ago (2011-07-30 01:06:51 UTC) #4
nduca
Thanks Ken! Great feedback, new rev uploaded.
9 years, 4 months ago (2011-08-01 22:41:54 UTC) #5
Ken Russell (switch to Gerrit)
9 years, 4 months ago (2011-08-01 22:53:29 UTC) #6
Thanks for the updates. LGTM

Powered by Google App Engine
This is Rietveld 408576698