Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: chrome/browser/resources/options/browser_options.js

Issue 7522025: Turn on session restore by default for mac on Lion (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: JS nits and comment correction Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/browser_options.js
diff --git a/chrome/browser/resources/options/browser_options.js b/chrome/browser/resources/options/browser_options.js
index e8b46fb4168c9f0734fd2230780f089c326c5692..14808b8e65eb1703cebc9fc4a240f25def9873a6 100644
--- a/chrome/browser/resources/options/browser_options.js
+++ b/chrome/browser/resources/options/browser_options.js
@@ -63,6 +63,14 @@ cr.define('options', function() {
$('toolbarShowBookmarksBar').onchange = function() {
chrome.send('toggleShowBookmarksBar');
};
+ var items = document.querySelectorAll('input[name=startup]');
+ for (i = 0; i < items.length; i++) {
+ items[i].onchange = function(event) {
+ chrome.send('setRestoreOnStartup', [event.target.value]);
+ chrome.send('coreOptionsUserMetricsAction',
+ [event.target.getAttribute('metric')]);
+ };
+ }
$('defaultSearchManageEnginesButton').onclick = function(event) {
OptionsPage.navigateToPage('searchEngines');
chrome.send('coreOptionsUserMetricsAction',
@@ -258,6 +266,19 @@ cr.define('options', function() {
},
/**
+ * Updates the startup radio group with the given value.
+ * @param {number} value the preference value being set.
+ * @private
+ */
+ updateRestoreOnStartup_: function(value) {
+ var items = document.querySelectorAll('input[name=startup]');
+ for (i = 0; i < items.length; i++) {
+ if (items[i].value == value)
+ items[i].checked = true;
+ }
+ },
+
+ /**
* Updates the startup pages list with the given entries.
* @param {Array} pages List of startup pages.
* @private
@@ -510,6 +531,10 @@ cr.define('options', function() {
defaultManaged);
};
+ BrowserOptions.updateRestoreOnStartup = function(value) {
+ BrowserOptions.getInstance().updateRestoreOnStartup_(value);
+ };
+
BrowserOptions.updateStartupPages = function(pages) {
BrowserOptions.getInstance().updateStartupPages_(pages);
};

Powered by Google App Engine
This is Rietveld 408576698