Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Unified Diff: chrome/test/webdriver/automation.h

Issue 7522024: Refactor chromedriver's script execution to reduce amount of custom Value parsing. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ... Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/webdriver/automation.h
diff --git a/chrome/test/webdriver/automation.h b/chrome/test/webdriver/automation.h
index 13e9228c134469c0d6ad7bdb371cbfc8b3a4efd0..b620a37a4bd632fc5d9dcaa0cd498ff5f0e9e0a5 100644
--- a/chrome/test/webdriver/automation.h
+++ b/chrome/test/webdriver/automation.h
@@ -27,14 +27,11 @@ class DictionaryValue;
class ListValue;
}
-namespace gfx {
-class Point;
-}
-
namespace webdriver {
class Error;
class FramePath;
+class Point;
// Creates and controls the Chrome instance.
// This class should be created and accessed on a single thread.
@@ -83,7 +80,7 @@ class Automation {
// Drag and drop the file paths to the given location.
void DragAndDropFilePaths(int tab_id,
- const gfx::Point& location,
+ const Point& location,
const std::vector<FilePath::StringType>& paths,
Error** error);
@@ -107,18 +104,18 @@ class Automation {
base::DictionaryValue* cookie_dict,
Error** error);
- void MouseMove(int tab_id, const gfx::Point& p, Error** error);
+ void MouseMove(int tab_id, const Point& p, Error** error);
void MouseClick(int tab_id,
- const gfx::Point& p,
+ const Point& p,
automation::MouseButton button,
Error** error);
void MouseDrag(int tab_id,
- const gfx::Point& start,
- const gfx::Point& end,
+ const Point& start,
+ const Point& end,
Error** error);
- void MouseButtonDown(int tab_id, const gfx::Point& p, Error** error);
- void MouseButtonUp(int tab_id, const gfx::Point& p, Error** error);
- void MouseDoubleClick(int tab_id, const gfx::Point& p, Error** error);
+ void MouseButtonDown(int tab_id, const Point& p, Error** error);
+ void MouseButtonUp(int tab_id, const Point& p, Error** error);
+ void MouseDoubleClick(int tab_id, const Point& p, Error** error);
// Get persistent IDs for all the tabs currently open. These IDs can be used
// to identify the tab as long as the tab exists.

Powered by Google App Engine
This is Rietveld 408576698