Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1280)

Unified Diff: chrome/test/webdriver/webdriver_util.cc

Issue 7522024: Refactor chromedriver's script execution to reduce amount of custom Value parsing. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/webdriver/webdriver_util.h ('k') | chrome/test/webdriver/webdriver_util_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/webdriver/webdriver_util.cc
diff --git a/chrome/test/webdriver/utility_functions.cc b/chrome/test/webdriver/webdriver_util.cc
similarity index 63%
rename from chrome/test/webdriver/utility_functions.cc
rename to chrome/test/webdriver/webdriver_util.cc
index b6af9187b4e870460b7238367cb2d155d50f025f..45e080f378877a307f30559fc5ff90e609ecd48e 100644
--- a/chrome/test/webdriver/utility_functions.cc
+++ b/chrome/test/webdriver/webdriver_util.cc
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "chrome/test/webdriver/utility_functions.h"
+#include "chrome/test/webdriver/webdriver_util.h"
#include "base/basictypes.h"
#include "base/format_macros.h"
@@ -13,6 +13,8 @@
namespace webdriver {
+SkipParsing* kSkipParsing = NULL;
+
std::string GenerateRandomID() {
uint64 msb = base::RandUint64();
uint64 lsb = base::RandUint64();
@@ -25,4 +27,18 @@ std::string JsonStringify(const Value* value) {
return json;
}
+ValueParser::ValueParser() { }
+
+ValueParser::~ValueParser() { }
+
} // namespace webdriver
+
+bool ValueConversionTraits<webdriver::SkipParsing>::SetFromValue(
+ const base::Value* value, const webdriver::SkipParsing* t) {
+ return true;
+}
+
+bool ValueConversionTraits<webdriver::SkipParsing>::CanConvert(
+ const base::Value* value) {
+ return true;
+}
« no previous file with comments | « chrome/test/webdriver/webdriver_util.h ('k') | chrome/test/webdriver/webdriver_util_mac.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698