Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Unified Diff: chrome/test/webdriver/commands/webelement_commands.cc

Issue 7522024: Refactor chromedriver's script execution to reduce amount of custom Value parsing. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/webdriver/commands/mouse_commands.cc ('k') | chrome/test/webdriver/dispatch.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/webdriver/commands/webelement_commands.cc
diff --git a/chrome/test/webdriver/commands/webelement_commands.cc b/chrome/test/webdriver/commands/webelement_commands.cc
index c76c66b6e7e7a2b0fed7e4dae7bcc8b5e30da3cc..05a8b66ba13edd7696dabb58e2185d22c2a75381 100644
--- a/chrome/test/webdriver/commands/webelement_commands.cc
+++ b/chrome/test/webdriver/commands/webelement_commands.cc
@@ -13,10 +13,9 @@
#include "base/values.h"
#include "chrome/test/webdriver/commands/response.h"
#include "chrome/test/webdriver/session.h"
+#include "chrome/test/webdriver/webdriver_basic_types.h"
#include "chrome/test/webdriver/webdriver_error.h"
#include "third_party/webdriver/atoms.h"
-#include "ui/gfx/point.h"
-#include "ui/gfx/size.h"
namespace webdriver {
@@ -280,7 +279,7 @@ bool ElementLocationInViewCommand::DoesGet() {
}
void ElementLocationInViewCommand::ExecuteGet(Response* const response) {
- gfx::Point location;
+ Point location;
Error* error = session_->GetElementLocationInView(element, &location);
if (error) {
response->SetError(error);
@@ -367,7 +366,7 @@ bool ElementSizeCommand::DoesGet() {
}
void ElementSizeCommand::ExecuteGet(Response* const response) {
- gfx::Size size;
+ Size size;
Error* error = session_->GetElementSize(
session_->current_target(), element, &size);
if (error) {
@@ -565,7 +564,7 @@ Error* ElementValueCommand::DragAndDropFilePaths() const {
paths.push_back(path);
}
- gfx::Point location;
+ Point location;
error = session_->GetClickableLocation(element, &location);
if (error) {
return error;
« no previous file with comments | « chrome/test/webdriver/commands/mouse_commands.cc ('k') | chrome/test/webdriver/dispatch.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698