Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Unified Diff: chrome/test/webdriver/automation.h

Issue 7522024: Refactor chromedriver's script execution to reduce amount of custom Value parsing. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/automation/value_conversion_util.h ('k') | chrome/test/webdriver/automation.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/webdriver/automation.h
diff --git a/chrome/test/webdriver/automation.h b/chrome/test/webdriver/automation.h
index dcb6dba0494ce7bc78bc7e1ac3c5f8d76690dccd..3886c948f32bb32ec1d42c0d649c9045131355cd 100644
--- a/chrome/test/webdriver/automation.h
+++ b/chrome/test/webdriver/automation.h
@@ -26,14 +26,11 @@ class DictionaryValue;
class ListValue;
}
-namespace gfx {
-class Point;
-}
-
namespace webdriver {
class Error;
class FramePath;
+class Point;
// Creates and controls the Chrome instance.
// This class should be created and accessed on a single thread.
@@ -83,7 +80,7 @@ class Automation {
// Drag and drop the file paths to the given location.
void DragAndDropFilePaths(int tab_id,
- const gfx::Point& location,
+ const Point& location,
const std::vector<FilePath::StringType>& paths,
Error** error);
@@ -108,18 +105,18 @@ class Automation {
base::DictionaryValue* cookie_dict,
Error** error);
- void MouseMove(int tab_id, const gfx::Point& p, Error** error);
+ void MouseMove(int tab_id, const Point& p, Error** error);
void MouseClick(int tab_id,
- const gfx::Point& p,
+ const Point& p,
automation::MouseButton button,
Error** error);
void MouseDrag(int tab_id,
- const gfx::Point& start,
- const gfx::Point& end,
+ const Point& start,
+ const Point& end,
Error** error);
- void MouseButtonDown(int tab_id, const gfx::Point& p, Error** error);
- void MouseButtonUp(int tab_id, const gfx::Point& p, Error** error);
- void MouseDoubleClick(int tab_id, const gfx::Point& p, Error** error);
+ void MouseButtonDown(int tab_id, const Point& p, Error** error);
+ void MouseButtonUp(int tab_id, const Point& p, Error** error);
+ void MouseDoubleClick(int tab_id, const Point& p, Error** error);
// Get persistent IDs for all the tabs currently open. These IDs can be used
// to identify the tab as long as the tab exists.
« no previous file with comments | « chrome/test/automation/value_conversion_util.h ('k') | chrome/test/webdriver/automation.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698