Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Unified Diff: net/url_request/url_request_http_job.cc

Issue 7522014: Add WARN_UNUSED_RESULT to crypto/hmac.h (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase onto CL 7532020 and update remoting Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_mac_signature_unittest.cc ('k') | remoting/protocol/jingle_session.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request_http_job.cc
diff --git a/net/url_request/url_request_http_job.cc b/net/url_request/url_request_http_job.cc
index 7e989a8a2b1fde98e15750e5f13d0c1ac7adc949..13154725eb24985659703eb2af9e378d32982d57 100644
--- a/net/url_request/url_request_http_job.cc
+++ b/net/url_request/url_request_http_job.cc
@@ -75,9 +75,11 @@ void AddAuthorizationHeader(
}
if (!signature.AddHttpInfo(method, request_uri, host, port))
continue;
- request_info->extra_headers.SetHeader(
- HttpRequestHeaders::kAuthorization,
- signature.GenerateAuthorizationHeader());
+ std::string authorization_header;
+ if (!signature.GenerateAuthorizationHeader(&authorization_header))
+ continue;
+ request_info->extra_headers.SetHeader(HttpRequestHeaders::kAuthorization,
+ authorization_header);
return; // Only add the first valid header.
}
}
« no previous file with comments | « net/http/http_mac_signature_unittest.cc ('k') | remoting/protocol/jingle_session.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698