chrome/common/net/gaia/oauth_request_signer.cc - Issue 7522014: Add WARN_UNUSED_RESULT to crypto/hmac.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/net/gaia/oauth_request_signer.cc

Issue 7522014: Add WARN_UNUSED_RESULT to crypto/hmac.h (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase onto CL 7532020 and update remoting Created 9 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/net/gaia/oauth_request_signer.cc

diff --git a/chrome/common/net/gaia/oauth_request_signer.cc b/chrome/common/net/gaia/oauth_request_signer.cc

index dd2b6d85535fd4b6bce06d704ae5187ecaf4019b..41b9fc036f89d2c65e446e306a928559887938bc 100644

--- a/chrome/common/net/gaia/oauth_request_signer.cc

+++ b/chrome/common/net/gaia/oauth_request_signer.cc

@@ -204,8 +204,8 @@ bool SignHmacSha1(const std::string& text,

crypto::HMAC hmac(crypto::HMAC::SHA1);

DCHECK(hmac.DigestLength() == kHmacDigestLength);

unsigned char digest[kHmacDigestLength];

- hmac.Init(key);

- bool result = hmac.Sign(text, digest, kHmacDigestLength) &&

+ bool result = hmac.Init(key) &&

+ hmac.Sign(text, digest, kHmacDigestLength) &&

base::Base64Encode(std::string(reinterpret_cast<const char*>(digest),

kHmacDigestLength),

signature_return);

« no previous file with comments | « chrome/browser/internal_auth.cc ('k') | crypto/hmac.h » ('j') | no next file with comments »