Add WARN_UNUSED_RESULT to crypto/hmac.h

net/http/http_mac_signature.h

Index: net/http/http_mac_signature.h
diff --git a/net/http/http_mac_signature.h b/net/http/http_mac_signature.h
index 00191e1aec362ad607df3cdb12416216a3e16dd7..f04d2b6d5666b392f8fa6c169aa0fcacf66f0c94 100644
--- a/net/http/http_mac_signature.h
+++ b/net/http/http_mac_signature.h
@@ -39,20 +39,24 @@ class NET_TEST HttpMacSignature {
                    const std::string& host,
                    int port);
 
-  // Returns the value of the Authorization header for use in an HTTP request.
-  std::string GenerateAuthorizationHeader();
+  // Generates a value suitable for the Authorization header of an HTTP

[wtc, 2011/07/28 18:11:41]

The first sentence should read:
  Generates the Authorization header for use in an HTTP request.

+  // request. If successfully generated, returns true and stores the resultant
+  // header in |*header|.
+  bool GenerateAuthorizationHeader(std::string* header);
 
  private:
   FRIEND_TEST_ALL_PREFIXES(HttpMacSignatureTest, GenerateHeaderString);
   FRIEND_TEST_ALL_PREFIXES(HttpMacSignatureTest, GenerateNormalizedRequest);
   FRIEND_TEST_ALL_PREFIXES(HttpMacSignatureTest, GenerateMAC);
 
-  std::string GenerateHeaderString(const std::string& age,
-                                   const std::string& nonce);
+  bool GenerateHeaderString(const std::string& age,
+                            const std::string& nonce,
+                            std::string* header);
   std::string GenerateNormalizedRequest(const std::string& age,

[Denis Lagno, 2011/07/28 08:13:37]

nit: now this method looks inconsistent among surrounding methods.

on the one hand, all surrounding methods are conceptually similar.
on the other hand now they use different styles of returning result.

                                         const std::string& nonce);
-  std::string GenerateMAC(const std::string& age,
-                          const std::string& nonce);
+  bool GenerateMAC(const std::string& age,
+                   const std::string& nonce,
+                   std::string* mac);
 
   std::string id_;
   base::Time creation_date_;