net/url_request/url_request_http_job.cc - Issue 7522014: Add WARN_UNUSED_RESULT to crypto/hmac.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/url_request/url_request_http_job.cc

Issue 7522014: Add WARN_UNUSED_RESULT to crypto/hmac.h (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix a few more unchecked places from the clang bots Created 9 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/url_request/url_request_http_job.cc

diff --git a/net/url_request/url_request_http_job.cc b/net/url_request/url_request_http_job.cc

index 11ea297d37e266ecf8d590b2c94c0fcae2312d05..26f6e161f6c65f1ff55b792a2413eb098b76c712 100644

--- a/net/url_request/url_request_http_job.cc

+++ b/net/url_request/url_request_http_job.cc

@@ -75,9 +75,12 @@ void AddAuthorizationHeader(

}

if (!signature.AddHttpInfo(method, request_uri, host, port))

continue;

+ std::string authorization_header;

+ if (!signature.GenerateAuthorizationHeader(&authorization_header))

+ continue;

request_info->extra_headers.SetHeader(

HttpRequestHeaders::kAuthorization,

- signature.GenerateAuthorizationHeader());

+ authorization_header);

return; // Only add the first valid header.

}