crypto/hmac_mac.cc - Issue 7522014: Add WARN_UNUSED_RESULT to crypto/hmac.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: crypto/hmac_mac.cc

Issue 7522014: Add WARN_UNUSED_RESULT to crypto/hmac.h (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix a few more unchecked places from the clang bots Created 9 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: crypto/hmac_mac.cc

diff --git a/crypto/hmac_mac.cc b/crypto/hmac_mac.cc

index f9a00cda8adaab7da1a65f24187b5b6f0a70e812..36caa0df8ebf71c50c51f0285469857422294960 100644

--- a/crypto/hmac_mac.cc

+++ b/crypto/hmac_mac.cc

@@ -42,6 +42,12 @@ HMAC::~HMAC() {

bool HMAC::Sign(const base::StringPiece& data,

unsigned char* digest,

int digest_length) const {

+ if (plat_->key_.empty()) {

+ // Init has not been called or has failed.

+ NOTREACHED();

+ return false;

+ }

CCHmacAlgorithm algorithm;

int algorithm_digest_length;

switch (hash_alg_) {