Add WARN_UNUSED_RESULT to crypto/hmac.h

net/http/http_mac_signature_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "testing/gtest/include/gtest/gtest.h"
 #include "net/http/http_mac_signature.h"
 
 namespace net {
 
 TEST(HttpMacSignatureTest, BogusAddStateInfo) {
@@ skipping 37 matching lines @@
                                      "adiMf03j0f3nOenc003r",
                                      "hmac-sha-1"));
   EXPECT_TRUE(signature.AddHttpInfo("GeT",
                                     "/pAth?to=%22enlightenment%22&dest=magic",
                                     "eXaMple.com",
                                     80));
 
   std::string age = "239034";
   std::string nonce = "mn4302j0n+32r2/f3r=";
 
+  std::string header_string;
+  EXPECT_TRUE(signature.GenerateHeaderString(age, nonce, &header_string));
   EXPECT_EQ("MAC id=\"dfoi30j0qnf\", "
             "nonce=\"239034:mn4302j0n+32r2/f3r=\", "
             "mac=\"GrkHtPKzB1m1dCHfa7OCWOw6EQ==\"",
-            signature.GenerateHeaderString(age, nonce));
+            header_string);
 }
 
 
 TEST(HttpMacSignatureTest, GenerateNormalizedRequest) {
   HttpMacSignature signature;
   EXPECT_TRUE(signature.AddStateInfo("dfoi30j0qnf",
                                      base::Time::Now(),
                                      "adiMf03j0f3nOenc003r",
                                      "hmac-sha-1"));
   EXPECT_TRUE(signature.AddHttpInfo("GeT",
@@ skipping 21 matching lines @@
                                      "adiMf03j0f3nOenc003r",
                                      "hmac-sha-1"));
   EXPECT_TRUE(signature.AddHttpInfo("GeT",
                                      "/pAth?to=%22enlightenment%22&dest=magic",
                                      "eXaMple.com",
                                      80));
 
   std::string age = "239034";
   std::string nonce = "mn4302j0n+32r2/f3r=";
 
-  EXPECT_EQ("GrkHtPKzB1m1dCHfa7OCWOw6EQ==",
-            signature.GenerateMAC(age, nonce));
+  std::string mac;
+  EXPECT_TRUE(signature.GenerateMAC(age, nonce, &mac));
+  EXPECT_EQ("GrkHtPKzB1m1dCHfa7OCWOw6EQ==", mac);
 }
 }