Add WARN_UNUSED_RESULT to crypto/hmac.h

chrome/browser/internal_auth.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/internal_auth.h"
 
 #include <algorithm>
 #include <deque>
 
 #include "base/base64.h"
@@ skipping 233 matching lines @@
   }
 
   void ChangeKey(const std::string& key) {
     old_key_.swap(key_);
     key_.clear();
     old_engine_.swap(engine_);
     engine_.reset(NULL);
 
     if (key.size() != kKeySizeInBytes)
       return;
-    engine_.reset(new crypto::HMAC(crypto::HMAC::SHA256));
-    engine_->Init(key);
+    scoped_ptr<crypto::HMAC> new_engine(
+        new crypto::HMAC(crypto::HMAC::SHA256));
+    if (!new_engine->Init(key))
+      return;
+    engine_.swap(new_engine);
     key_ = key;
     key_change_tick_ = GetCurrentTick();
   }
 
  private:
   static int get_verification_window_ticks() {
     return InternalAuthVerification::get_verification_window_ticks();
   }
 
   // Returns tick bound to given passport on success or zero on failure.
@@ skipping 74 matching lines @@
   void GenerateNewKey() {
     DCHECK(CalledOnValidThread());
     if (!timer_.IsRunning()) {
       timer_.Start(
           base::TimeDelta::FromMicroseconds(
               kKeyRegenerationSoftTicks * kTickUs),
           this,
           &InternalAuthGenerationService::GenerateNewKey);
     }
 
-    engine_.reset(new crypto::HMAC(crypto::HMAC::SHA256));
+    scoped_ptr<crypto::HMAC> new_engine(
+        new crypto::HMAC(crypto::HMAC::SHA256));
     std::string key = base::RandBytesAsString(kKeySizeInBytes);
-    engine_->Init(key);
+    if (!new_engine->Init(key))
+      return;
+    engine_.swap(new_engine);
     key_regeneration_tick_ = GetCurrentTick();
     g_verification_service.Get().ChangeKey(key);
     std::fill(key.begin(), key.end(), 0);
   }
 
   // Returns zero on failure.
   int64 GetUnusedTick(const std::string& domain) {
     DCHECK(CalledOnValidThread());
     if (engine_ == NULL) {
       NOTREACHED();
@@ skipping 108 matching lines @@
   return g_generation_service.Get().GeneratePassport(domain, var_value_map, 0);
 }
 
 // static
 void InternalAuthGeneration::GenerateNewKey() {
   g_generation_service.Get().GenerateNewKey();
 }
 
 }  // namespace browser