Add WARN_UNUSED_RESULT to crypto/hmac.h

net/url_request/url_request_http_job.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/url_request/url_request_http_job.h"
 
 #include "base/bind.h"
 #include "base/base_switches.h"
 #include "base/command_line.h"
 #include "base/compiler_specific.h"
@@ skipping 57 matching lines @@
   for (size_t i = 0; i < cookie_infos.size(); ++i) {
     HttpMacSignature signature;
     if (!signature.AddStateInfo(cookie_infos[i].name,
                                 cookie_infos[i].creation_date,
                                 cookie_infos[i].mac_key,
                                 cookie_infos[i].mac_algorithm)) {
       continue;
     }
     if (!signature.AddHttpInfo(method, request_uri, host, port))
       continue;
+    std::string authorization_header;
+    if (!signature.GenerateAuthorizationHeader(&authorization_header))
+      continue;
     request_info->extra_headers.SetHeader(
         HttpRequestHeaders::kAuthorization,
-        signature.GenerateAuthorizationHeader());
+        authorization_header);

[wtc, 2011/07/28 18:11:41]

Nit: this should fit on the previous line.

     return;  // Only add the first valid header.
   }
 }
 
 class HTTPSProberDelegateImpl : public HTTPSProberDelegate {
  public:
   HTTPSProberDelegateImpl(const std::string& host, int max_age,
                           bool include_subdomains,
                           TransportSecurityState* sts)
       : host_(host),
@@ skipping 1474 matching lines @@
   if (done_)
     return;
   done_ = true;
 
   RecordPerfHistograms(reason);
   if (reason == FINISHED)
     RecordCompressionHistograms();
 }
 
 }  // namespace net