Make one-ascii-character-string a symbol in its cache.

Make one-ascii-character-string a symbol in its cache.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=539

[iposva, 2008-10-21 04:33:46]

LGTM

-Ivan

http://codereview.chromium.org/7521/diff/1/2
File src/heap.cc (right):

http://codereview.chromium.org/7521/diff/1/2#newcode1505
Line 1505: Object* result = Heap::AllocateRawTwoByteString(1);
Is there a reason we do not symbolize one character two byte strings? Just no
frequent enough?

[Feng Qian, 2008-10-21 16:27:11]

http://codereview.chromium.org/7521/diff/1/2
File src/heap.cc (right):

http://codereview.chromium.org/7521/diff/1/2#newcode1505
Line 1505: Object* result = Heap::AllocateRawTwoByteString(1);
I viewed single_character_string_cache is a cache on top of symbol table, and
two-byte chars are not cached, so I didn't feel strongly to symbolize it.

On 2008/10/21 04:33:46, iposva wrote:
> Is there a reason we do not symbolize one character two byte strings? Just no
> frequent enough?