chrome/browser/ui/views/bookmarks/bookmark_context_menu_controller_views.cc - Issue 7520023: Converted IncognitoForced boolean policy into IncognitoModeAvailability enum policy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_context_menu_controller_views.cc

Issue 7520023: Converted IncognitoForced boolean policy into IncognitoModeAvailability enum policy. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Converted incognito pref functions to a class. Created 9 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/prefs/incognito_mode_prefs_unittest.cc ('K') | « chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/bookmarks/bookmark_context_menu_controller_views.cc

diff --git a/chrome/browser/ui/views/bookmarks/bookmark_context_menu_controller_views.cc b/chrome/browser/ui/views/bookmarks/bookmark_context_menu_controller_views.cc

index fe6ff6b1bb8e607ed257a821104c926cccfc6720..3ecebaa2b6b3c1134d7d055ecfcbef26e1b38a6c 100644

--- a/chrome/browser/ui/views/bookmarks/bookmark_context_menu_controller_views.cc

+++ b/chrome/browser/ui/views/bookmarks/bookmark_context_menu_controller_views.cc

@@ -10,6 +10,7 @@

#include "chrome/browser/bookmarks/bookmark_folder_editor_controller.h"

#include "chrome/browser/bookmarks/bookmark_model.h"

#include "chrome/browser/bookmarks/bookmark_utils.h"

+#include "chrome/browser/prefs/incognito_mode_prefs.h"

#include "chrome/browser/prefs/pref_service.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/ui/browser.h"

@@ -237,15 +238,20 @@ bool BookmarkContextMenuControllerViews::IsCommandEnabled(int id) const {

switch (id) {

case IDC_BOOKMARK_BAR_OPEN_INCOGNITO:

return !profile_->IsOffTheRecord() &&

- profile_->GetPrefs()->GetBoolean(prefs::kIncognitoEnabled);

+ IncognitoModePrefs::GetAvailability(profile_->GetPrefs()) !=

+ IncognitoModePrefs::DISABLED;

case IDC_BOOKMARK_BAR_OPEN_ALL_INCOGNITO:

return HasURLs() && !profile_->IsOffTheRecord() &&

- profile_->GetPrefs()->GetBoolean(prefs::kIncognitoEnabled);

+ IncognitoModePrefs::GetAvailability(profile_->GetPrefs()) !=

+ IncognitoModePrefs::DISABLED;

case IDC_BOOKMARK_BAR_OPEN_ALL:

- case IDC_BOOKMARK_BAR_OPEN_ALL_NEW_WINDOW:

return HasURLs();

+ case IDC_BOOKMARK_BAR_OPEN_ALL_NEW_WINDOW:

+ return HasURLs() &&

+ IncognitoModePrefs::GetAvailability(profile_->GetPrefs()) !=

+ IncognitoModePrefs::FORCED;

case IDC_BOOKMARK_BAR_RENAME_FOLDER:

case IDC_BOOKMARK_BAR_EDIT: