Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3701)

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm

Issue 7520023: Converted IncognitoForced boolean policy into IncognitoModeAvailability enum policy. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Removed unnecessary comment. Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm
diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm
index 69fb3b67c42bdc627a941db605785971d648ee73..b390da4a83ac9f8cbe2083677bfb6be6e8fae592 100644
--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm
+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm
@@ -11,6 +11,7 @@
#include "chrome/browser/bookmarks/bookmark_model.h"
#include "chrome/browser/bookmarks/bookmark_utils.h"
#include "chrome/browser/extensions/extension_service.h"
+#include "chrome/browser/prefs/incognito_mode_prefs.h"
#include "chrome/browser/prefs/pref_service.h"
#include "chrome/browser/profiles/profile.h"
#import "chrome/browser/themes/theme_service.h"
@@ -1085,12 +1086,23 @@ void RecordAppLaunch(Profile* profile, GURL url) {
return NO;
}
+ Profile* profile = browser_->profile();
// If this is an incognito window, don't allow "open in incognito".
if ((action == @selector(openBookmarkInIncognitoWindow:)) ||
(action == @selector(openAllBookmarksIncognitoWindow:))) {
- Profile* profile = browser_->profile();
if (profile->IsOffTheRecord() ||
- !profile->GetPrefs()->GetBoolean(prefs::kIncognitoEnabled)) {
+ IncognitoModePrefs::GetAvailability(profile->GetPrefs()) ==
+ IncognitoModePrefs::DISABLED) {
+ return NO;
+ }
+ }
+
+ // If Incognito mode is forced, do not let open bookmarks in normal window.
+ if ((action == @selector(openBookmark:)) ||
+ (action == @selector(openAllBookmarksNewWindow:)) ||
+ (action == @selector(openAllBookmarks:))) {
+ if (IncognitoModePrefs::GetAvailability(profile->GetPrefs()) ==
+ IncognitoModePrefs::FORCED) {
return NO;
}
}
« no previous file with comments | « chrome/browser/ui/browser_init.cc ('k') | chrome/browser/ui/views/bookmarks/bookmark_context_menu_controller_views.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698