Converted IncognitoForced boolean policy into IncognitoModeAvailability enum policy.

chrome/browser/prefs/incognito_mode_prefs_unittest.cc

+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/prefs/incognito_mode_prefs.h"
+
+#include "testing/gtest/include/gtest/gtest.h"
+#include "chrome/test/testing_pref_service.h"
+#include "chrome/common/pref_names.h"

[Mattias Nissler (ping if slow), 2011/07/29 10:33:23]

alphabetize

[rustema, 2011/07/30 06:17:37]

Done.

+
+class IncognitoModePrefsTest : public testing::Test {
+ protected:
+  virtual void SetUp() {
+    prefs_.reset(new TestingPrefService());
+    IncognitoModePrefs::RegisterUserPrefs(prefs_.get());
+  }
+
+  scoped_ptr<TestingPrefService> prefs_;
+};
+
+TEST_F(IncognitoModePrefsTest, IntToAvailability) {
+  ASSERT_EQ(0, IncognitoModePrefs::ENABLED);
+  ASSERT_EQ(1, IncognitoModePrefs::DISABLED);
+  ASSERT_EQ(2, IncognitoModePrefs::FORCED);
+
+  IncognitoModePrefs::Availability incognito;
+  EXPECT_TRUE(IncognitoModePrefs::IntToAvailability(0, &incognito));
+  EXPECT_EQ(IncognitoModePrefs::ENABLED, incognito);
+  EXPECT_TRUE(IncognitoModePrefs::IntToAvailability(1, &incognito));
+  EXPECT_EQ(IncognitoModePrefs::DISABLED, incognito);
+  EXPECT_TRUE(IncognitoModePrefs::IntToAvailability(2, &incognito));
+  EXPECT_EQ(IncognitoModePrefs::FORCED, incognito);
+
+  EXPECT_FALSE(IncognitoModePrefs::IntToAvailability(10, &incognito));
+  EXPECT_EQ(IncognitoModePrefs::ENABLED, incognito);
+  EXPECT_FALSE(IncognitoModePrefs::IntToAvailability(-1, &incognito));
+  EXPECT_EQ(IncognitoModePrefs::ENABLED, incognito);
+}
+
+TEST_F(IncognitoModePrefsTest, GetAvailability) {
+  prefs_->SetUserPref(prefs::kIncognitoModeAvailability,
+                      Value::CreateIntegerValue(IncognitoModePrefs::ENABLED));
+  EXPECT_EQ(IncognitoModePrefs::ENABLED,
+            IncognitoModePrefs::GetAvailability(prefs_.get()));
+
+  prefs_->SetUserPref(prefs::kIncognitoModeAvailability,
+                      Value::CreateIntegerValue(IncognitoModePrefs::DISABLED));
+  EXPECT_EQ(IncognitoModePrefs::DISABLED,
+            IncognitoModePrefs::GetAvailability(prefs_.get()));
+
+  prefs_->SetUserPref(prefs::kIncognitoModeAvailability,
+                      Value::CreateIntegerValue(IncognitoModePrefs::FORCED));
+  EXPECT_EQ(IncognitoModePrefs::FORCED,
+            IncognitoModePrefs::GetAvailability(prefs_.get()));
+}
+
+typedef IncognitoModePrefsTest IncognitoModePrefsDeathTest;
+
+TEST_F(IncognitoModePrefsDeathTest, GetAvailabilityBadValue) {
+  prefs_->SetUserPref(prefs::kIncognitoModeAvailability,
+                      Value::CreateIntegerValue(-1));
+  EXPECT_DEBUG_DEATH({

[Mattias Nissler (ping if slow), 2011/07/29 11:29:08]

Pawel, what's the current policy on death tests? I remember there was a
discussion, but do not remember the results and cannot find clear direction from
the chromium-dev archives.

+    IncognitoModePrefs::Availability availability =
+        IncognitoModePrefs::GetAvailability(prefs_.get());
+    EXPECT_EQ(IncognitoModePrefs::ENABLED, availability);
+  }, "");
+}