chrome/browser/prefs/incognito_mode_availability_prefs.h - Issue 7520023: Converted IncognitoForced boolean policy into IncognitoModeAvailability enum policy.

Side by Side Diff: chrome/browser/prefs/incognito_mode_availability_prefs.h

Issue 7520023: Converted IncognitoForced boolean policy into IncognitoModeAvailability enum policy. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Created 9 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/prefs/command_line_pref_store.cc ('K') | « chrome/browser/prefs/command_line_pref_store_unittest.cc ('k') | chrome/browser/prefs/incognito_mode_availability_prefs.cc » ('j') | chrome/browser/ui/browser.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_PREFS_INCOGNITO_MODE_AVAILABILITY_PREFS_H_

	6 #define CHROME_BROWSER_PREFS_INCOGNITO_MODE_AVAILABILITY_PREFS_H_
	Mattias Nissler (ping if slow) 2011/07/28 11:08:50 #pragma once #pragma once rustema 2011/07/29 06:49:23 Done. Show quoted text On 2011/07/28 11:08:50, Mattias Nissler wrote: > #pragma once Done.
	7

	8 namespace IncognitoModeAvailabilityPrefs {
	Mattias Nissler (ping if slow) 2011/07/28 11:08:50 I suggest you make this a class, rename the enum t I suggest you make this a class, rename the enum to something shorter, and provide static functions getting/setting the value given a PrefService. Also, moving the registration of the pref here would be nice to have everything in one place. Check out chrome/browser/prefs/session_startup_pref.cc for a similar situation. Bernhard Bauer 2011/07/28 11:34:03 What Mattias said. How about naming the class just Show quoted text On 2011/07/28 11:08:50, Mattias Nissler wrote: > I suggest you make this a class, rename the enum to something shorter, and > provide static functions getting/setting the value given a PrefService. Also, > moving the registration of the pref here would be nice to have everything in one > place. Check out chrome/browser/prefs/session_startup_pref.cc for a similar > situation. What Mattias said. How about naming the class just IncognitoModePrefs and the enum Availability? rustema 2011/07/29 06:49:23 Done. Show quoted text On 2011/07/28 11:08:50, Mattias Nissler wrote: > I suggest you make this a class, rename the enum to something shorter, and > provide static functions getting/setting the value given a PrefService. Also, > moving the registration of the pref here would be nice to have everything in one > place. Check out chrome/browser/prefs/session_startup_pref.cc for a similar > situation. Done. rustema 2011/07/29 06:49:23 Done. Show quoted text On 2011/07/28 11:34:03, Bernhard Bauer wrote: > On 2011/07/28 11:08:50, Mattias Nissler wrote: > > I suggest you make this a class, rename the enum to something shorter, and > > provide static functions getting/setting the value given a PrefService. Also, > > moving the registration of the pref here would be nice to have everything in > one > > place. Check out chrome/browser/prefs/session_startup_pref.cc for a similar > > situation. > > What Mattias said. How about naming the class just IncognitoModePrefs and the > enum Availability? Done.
	9

	10 // Possible values for Incognito mode availability pref. Please, do not change

	11 // the order of entries since numeric values are exposed to users.

	12 enum IncognitoModeAvailability {

	13 // Incognito mode enabled. Users may open pages in both Incognito mode and

	14 // normal mode (the default behaviour).

	15 ENABLED = 0,

	16 // Incognito mode disabled. Users may not open pages in Incognito mode.

	17 // Only normal mode is available for browsing.

	18 DISABLED = 1,
	Bernhard Bauer 2011/07/28 11:34:03 Why do you explicitly list the enum values? Why do you explicitly list the enum values? rustema 2011/07/29 06:49:23 To make it clearer and easier to see which policy Show quoted text On 2011/07/28 11:34:03, Bernhard Bauer wrote: > Why do you explicitly list the enum values? To make it clearer and easier to see which policy values they correspond to. Removed.
	19 // Incognito mode forced. Users may open pages ONLY in Incognito mode.

	20 // Normal mode is not available for browsing.

	21 FORCED = 2,

	22

	23 AVAILABILITY_NUM_TYPES

	24 };

	25

	26 bool IntToIngocnitoModeAvailability(int in_value,

	27 IncognitoModeAvailability* out_value);

	28

	29 } // namespace IncognitoModeAvailability
	Mattias Nissler (ping if slow) 2011/07/28 11:08:50 incorrect name. incorrect name. rustema 2011/07/29 06:49:23 Done. Show quoted text On 2011/07/28 11:08:50, Mattias Nissler wrote: > incorrect name. Done.
	30

	31 #endif // CHROME_BROWSER_PREFS_INCOGNITO_MODE_AVAILABILITY_PREFS_H_

OLD	NEW