Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 7520011: WebUI TaskManager: make it default on Chrome OS (Closed)

Created:
9 years, 5 months ago by yoshiki
Modified:
9 years, 4 months ago
Reviewers:
mazda, xiyuan
CC:
chromium-reviews, cbentzel+watch_chromium.org, tburkard+watch_chromium.org, Erik does not do reviews, Aaron Boodman, dominich+watch_chromium.org, Paweł Hajdan Jr., mmenke
Visibility:
Public.

Description

WebUI TaskManager: make it default on Chrome OS And fixes the code of task manager and following tests which didn't work correctly on WebUI TaskManager. - TaskManagerBrowserTest.ShutdownWhileOpen - ExtensionApiTest.ProcessesVsTaskManager - PrerenderBrowserTest.PrerenderTaskManager BUG=chromium-os:13885 TEST=trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95015

Patch Set 1 #

Total comments: 8
Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -68 lines) Patch
M build/common.gypi View 5 chunks +17 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_processes_apitest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/prerender/prerender_browsertest.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/task_manager/task_manager_browsertest.cc View 3 chunks +3 lines, -60 lines 0 comments Download
A chrome/browser/task_manager/task_manager_browsertest_util.h View 1 chunk +131 lines, -0 lines 8 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/task_manager_dialog.cc View 4 chunks +10 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/task_manager_handler.cc View 3 chunks +12 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_notification_types.h View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
yoshiki
9 years, 4 months ago (2011-07-29 16:20:33 UTC) #1
xiyuan
LGTM with nits http://codereview.chromium.org/7520011/diff/1/chrome/browser/task_manager/task_manager_browsertest_util.h File chrome/browser/task_manager/task_manager_browsertest_util.h (right): http://codereview.chromium.org/7520011/diff/1/chrome/browser/task_manager/task_manager_browsertest_util.h#newcode21 chrome/browser/task_manager/task_manager_browsertest_util.h:21: class ResourceChangeObserver : public TaskManagerModelObserver { ...
9 years, 4 months ago (2011-07-29 18:04:56 UTC) #2
mazda
9 years, 4 months ago (2011-07-29 18:20:37 UTC) #3
LGTM with a nit

http://codereview.chromium.org/7520011/diff/1/chrome/browser/task_manager/tas...
File chrome/browser/task_manager/task_manager_browsertest_util.h (right):

http://codereview.chromium.org/7520011/diff/1/chrome/browser/task_manager/tas...
chrome/browser/task_manager/task_manager_browsertest_util.h:131: 
redundant line?

Powered by Google App Engine
This is Rietveld 408576698