Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 7519028: Remove some unneeded uses of wstring. (Closed)

Created:
9 years, 4 months ago by Torne
Modified:
9 years, 4 months ago
CC:
chromium-reviews, hclam+watch_chromium.org, acolwell+watch_chromium.org, fischman+watch_chromium.org, kkania, Paweł Hajdan Jr., jam, annacc+watch_chromium.org, joi+watch-content_chromium.org, ajwong+watch_chromium.org, vrk (LEFT CHROMIUM), ddorwin+watch_chromium.org, scherkus (not reviewing)
Visibility:
Public.

Description

Remove some unneeded uses of wstring. The automation proxy launcher is only producing ASCII log messages, so regular strings are fine. In the process, fix an unwanted & in one of the log messages which causes a format string error. The video capture test is generating a filename and should be using FILE_PATH_LITERAL to get the right kind of string for the platform. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96022

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -15 lines) Patch
M chrome/test/automation/proxy_launcher.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/automation/proxy_launcher.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M chrome/test/ui/ui_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_host_unittest.cc View 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Torne
Hi, would you mind taking a quick look at this? Should be trivial I hope ...
9 years, 4 months ago (2011-08-02 10:45:37 UTC) #1
Paweł Hajdan Jr.
LGTM
9 years, 4 months ago (2011-08-02 19:57:35 UTC) #2
scherkus (not reviewing)
LGTM
9 years, 4 months ago (2011-08-08 18:40:59 UTC) #3
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...
9 years, 4 months ago (2011-08-09 13:10:39 UTC) #4
commit-bot: I haz the power
Try job failure for 7519028-1 (retry) on linux for step "compile" (clobber build). It's a ...
9 years, 4 months ago (2011-08-09 13:34:00 UTC) #5
commit-bot: I haz the power
9 years, 4 months ago (2011-08-09 18:08:54 UTC) #6
Change committed as 96022

Powered by Google App Engine
This is Rietveld 408576698