Issue 7519024: Fix possible typos in RGB->YUV conversion

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7519024: Fix possible typos in RGB->YUV conversion (Closed)

Created:
9 years, 4 months ago by Hironori Bono

Modified:
9 years, 4 months ago

Reviewers:
Alpha Left Google

CC:
chromium-reviews, hclam+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, acolwell+watch_chromium.org, annacc+watch_chromium.org, ajwong+watch_chromium.org, vrk (LEFT CHROMIUM), scherkus (not reviewing)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix possible typos. This change just fixes a possible typo in RGB->YUV conversion formulae. (If I recall correctly, 'v = 112 * r - 94 * g - 18 * b' as written in <http://en.wikipedia.org/wiki/YUV>.) (I noticed this issue when I implement RGB->YUV conversion in YASM.) BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96756

Patch Set 1 : '' #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	media/base/yuv_convert_c.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
	M	media/base/yuv_convert_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Hironori Bono

Greetings, I just would like to send this change to figure out if it is ...

9 years, 4 months ago (2011-08-01 10:50:07 UTC) #1

Alpha Left Google

9 years, 4 months ago (2011-08-01 10:56:27 UTC) #2

LGTM.

I don't remember writing this code but this change looks good to me. Thanks for
spotting it!

Expand Messages | Collapse Messages