Fix testInstallExtensions by adding correct crx files.

Fix testInstallExtensions by adding correct crx files.

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95452

[Huyen, 2011-08-01 19:12:09]

Fixing test by adding correct crx files. Last submit included files that were
size 0 for some reason.

[kkania, 2011-08-01 20:19:52]

Did you fix the problem on windows? If not, you should only enable on mac/linux
or wait for the fix.

The commit might have failed if you used the commit queue, which I don't think
can handle binary files. You could ping maruel on chat or IRC and ask. You
should just run a try job and then commit manually.

[Huyen, 2011-08-04 17:36:10]

Please take another look. Thanks for helping me debug the windows problem.

On 2011/08/01 20:19:52, kkania wrote:
> Did you fix the problem on windows? If not, you should only enable on
mac/linux
> or wait for the fix.
> 
> The commit might have failed if you used the commit queue, which I don't think
> can handle binary files. You could ping maruel on chat or IRC and ask. You
> should just run a try job and then commit manually.

[kkania, 2011-08-04 17:51:20]

http://codereview.chromium.org/7518031/diff/5001/chrome/test/webdriver/test/c...
File chrome/test/webdriver/test/chromedriver_tests.py (right):

http://codereview.chromium.org/7518031/diff/5001/chrome/test/webdriver/test/c...
chrome/test/webdriver/test/chromedriver_tests.py:291: user_profile_zip =
archive_util.make_archive('profile', 'zip',
i know this is from an earlier CL, but I didn't notice the problem before. It's
bad form to create files in the checkout directory. It's better to put in the
out/... folder or a temporary spot.

Someone later may checkin a file with the same path. This will cause this to
delete that, or, the bots will fail on sync because the file already exists (if
for some reason the test has an exception and the file is never deleted).

Look at the use of tempfile in this file.

[Huyen, 2011-08-04 18:23:12]

Good catch, I've changed the code to write profile.zip to the same temp dir use
for the user-data-dir. Please take another look.

On 2011/08/04 17:51:20, kkania wrote:
>
http://codereview.chromium.org/7518031/diff/5001/chrome/test/webdriver/test/c...
> File chrome/test/webdriver/test/chromedriver_tests.py (right):
> 
>
http://codereview.chromium.org/7518031/diff/5001/chrome/test/webdriver/test/c...
> chrome/test/webdriver/test/chromedriver_tests.py:291: user_profile_zip =
> archive_util.make_archive('profile', 'zip',
> i know this is from an earlier CL, but I didn't notice the problem before.
It's
> bad form to create files in the checkout directory. It's better to put in the
> out/... folder or a temporary spot.
> 
> Someone later may checkin a file with the same path. This will cause this to
> delete that, or, the bots will fail on sync because the file already exists
(if
> for some reason the test has an exception and the file is never deleted).
> 
> Look at the use of tempfile in this file.

[kkania, 2011-08-04 18:30:36]

LGTM