Issue 7518030: Fix crashing bug with session sync enabled and opening developer tools.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7518030: Fix crashing bug with session sync enabled and opening developer tools. (Closed)

Created:
9 years, 4 months ago by Yaron

Modified:
9 years, 4 months ago

Reviewers:
commit-bot: I haz the power, sky

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fix crashing bug with session sync enabled and opening developer tools. BUG=91070 TEST=Run chrome with --enable-sync-sessions and open developer tools. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95040

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressed nit #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	chrome/browser/ui/browser_synced_window_delegate.cc	View	1	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Yaron

I discovered this while playing around with sessions. There's an explicit check in session_model_associator for ...

9 years, 4 months ago (2011-08-01 17:46:33 UTC) #1

sky

LGTM http://codereview.chromium.org/7518030/diff/1/chrome/browser/ui/browser_synced_window_delegate.cc File chrome/browser/ui/browser_synced_window_delegate.cc (right): http://codereview.chromium.org/7518030/diff/1/chrome/browser/ui/browser_synced_window_delegate.cc#newcode34 chrome/browser/ui/browser_synced_window_delegate.cc:34: if (browser) { nit: return browser ? browser->... ...

9 years, 4 months ago (2011-08-01 20:26:10 UTC) #2

Change committed as 95040

Expand Messages | Collapse Messages