Add sign in dialog for GCP->print preview integration.

Add sign in dialog for GCP->print preview integration.

BUG=http://code.google.com/p/chromium-os/issues/detail?id=16082
TEST=Make sure you are signed out.  Open print preview. Choose sign in from the printer drop down.  Should be able to sign in with the resulting dialog.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98124

[Albert Bodenhamer, 2011-08-22 23:11:45]

Merged with latest changes.  Please take a look when you have a chance.

[Scott Byer, 2011-08-23 23:57:33]

http://codereview.chromium.org/7518002/diff/8001/chrome/browser/printing/clou...
File chrome/browser/printing/cloud_print/cloud_print_url.cc (right):

http://codereview.chromium.org/7518002/diff/8001/chrome/browser/printing/clou...
chrome/browser/printing/cloud_print/cloud_print_url.cc:20:
"https%3A%2F%2Fwww.google.com%2Fcloudprint";
Should this be over-ridable in the prefs?

http://codereview.chromium.org/7518002/diff/8001/chrome/browser/ui/webui/clou...
File chrome/browser/ui/webui/cloud_print_signin_dialog.cc (right):

http://codereview.chromium.org/7518002/diff/8001/chrome/browser/ui/webui/clou...
chrome/browser/ui/webui/cloud_print_signin_dialog.cc:59: const
NotificationSource& source,
nit: indent

http://codereview.chromium.org/7518002/diff/8001/chrome/browser/ui/webui/clou...
chrome/browser/ui/webui/cloud_print_signin_dialog.cc:108: 
nit: extra blank line

http://codereview.chromium.org/7518002/diff/8001/chrome/browser/ui/webui/clou...
chrome/browser/ui/webui/cloud_print_signin_dialog.cc:112: // browser window
never responding to input again.  Figure out why.
Add a bug to track this with and put the URL here.

http://codereview.chromium.org/7518002/diff/8001/chrome/browser/ui/webui/clou...
chrome/browser/ui/webui/cloud_print_signin_dialog.cc:182: }
Missing // namespace comment.

[Albert Bodenhamer, 2011-08-24 01:00:07]

http://codereview.chromium.org/7518002/diff/8001/chrome/browser/printing/clou...
File chrome/browser/printing/cloud_print/cloud_print_url.cc (right):

http://codereview.chromium.org/7518002/diff/8001/chrome/browser/printing/clou...
chrome/browser/printing/cloud_print/cloud_print_url.cc:20:
"https%3A%2F%2Fwww.google.com%2Fcloudprint";
On 2011/08/23 23:57:33, Scott Byer wrote:
> Should this be over-ridable in the prefs?

Done.

http://codereview.chromium.org/7518002/diff/8001/chrome/browser/ui/webui/clou...
File chrome/browser/ui/webui/cloud_print_signin_dialog.cc (right):

http://codereview.chromium.org/7518002/diff/8001/chrome/browser/ui/webui/clou...
chrome/browser/ui/webui/cloud_print_signin_dialog.cc:59: const
NotificationSource& source,
On 2011/08/23 23:57:33, Scott Byer wrote:
> nit: indent

Done.

http://codereview.chromium.org/7518002/diff/8001/chrome/browser/ui/webui/clou...
chrome/browser/ui/webui/cloud_print_signin_dialog.cc:108: 
On 2011/08/23 23:57:33, Scott Byer wrote:
> nit: extra blank line

Done.

http://codereview.chromium.org/7518002/diff/8001/chrome/browser/ui/webui/clou...
chrome/browser/ui/webui/cloud_print_signin_dialog.cc:112: // browser window
never responding to input again.  Figure out why.
On 2011/08/23 23:57:33, Scott Byer wrote:
> Add a bug to track this with and put the URL here.

Done.

http://codereview.chromium.org/7518002/diff/8001/chrome/browser/ui/webui/clou...
chrome/browser/ui/webui/cloud_print_signin_dialog.cc:182: }
On 2011/08/23 23:57:33, Scott Byer wrote:
> Missing // namespace comment.

Done.

[Scott Byer, 2011-08-24 18:28:05]

LGTM

On 2011/08/24 01:00:07, Albert Bodenhamer wrote:
>
http://codereview.chromium.org/7518002/diff/8001/chrome/browser/printing/clou...
> File chrome/browser/printing/cloud_print/cloud_print_url.cc (right):
> 
>
http://codereview.chromium.org/7518002/diff/8001/chrome/browser/printing/clou...
> chrome/browser/printing/cloud_print/cloud_print_url.cc:20:
> "https%3A%2F%2Fwww.google.com%2Fcloudprint";
> On 2011/08/23 23:57:33, Scott Byer wrote:
> > Should this be over-ridable in the prefs?
> 
> Done.
> 
>
http://codereview.chromium.org/7518002/diff/8001/chrome/browser/ui/webui/clou...
> File chrome/browser/ui/webui/cloud_print_signin_dialog.cc (right):
> 
>
http://codereview.chromium.org/7518002/diff/8001/chrome/browser/ui/webui/clou...
> chrome/browser/ui/webui/cloud_print_signin_dialog.cc:59: const
> NotificationSource& source,
> On 2011/08/23 23:57:33, Scott Byer wrote:
> > nit: indent
> 
> Done.
> 
>
http://codereview.chromium.org/7518002/diff/8001/chrome/browser/ui/webui/clou...
> chrome/browser/ui/webui/cloud_print_signin_dialog.cc:108: 
> On 2011/08/23 23:57:33, Scott Byer wrote:
> > nit: extra blank line
> 
> Done.
> 
>
http://codereview.chromium.org/7518002/diff/8001/chrome/browser/ui/webui/clou...
> chrome/browser/ui/webui/cloud_print_signin_dialog.cc:112: // browser window
> never responding to input again.  Figure out why.
> On 2011/08/23 23:57:33, Scott Byer wrote:
> > Add a bug to track this with and put the URL here.
> 
> Done.
> 
>
http://codereview.chromium.org/7518002/diff/8001/chrome/browser/ui/webui/clou...
> chrome/browser/ui/webui/cloud_print_signin_dialog.cc:182: }
> On 2011/08/23 23:57:33, Scott Byer wrote:
> > Missing // namespace comment.
> 
> Done.

[commit-bot: I haz the power, 2011-08-24 21:58:17]

Change committed as 98124