Issue 7517020: First pass at removal of unneeded dependencies on skia\ext\platform_canvas.h

Issue 7517020: First pass at removal of unneeded dependencies on skia\ext\platform_canvas.h (Closed)

Created:
9 years, 5 months ago by Jeff Timanus

Modified:
9 years, 4 months ago

Reviewers:
sky, tony, alokp, darin (slow to review), brettw, ananta, scherkus (not reviewing)

CC:
chromium-reviews, hclam+watch_chromium.org, sjl, ddorwin+watch_chromium.org, fischman+watch_chromium.org, jam, acolwell+watch_chromium.org, annacc+watch_chromium.org, joi+watch-content_chromium.org, pam+watch_chromium.org, ajwong+watch_chromium.org, vrk (LEFT CHROMIUM), darin-cc_chromium.org, scherkus (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

First pass at removal of unneeded dependencies on skia\ext\platform_canvas.h All 'low-hanging' platform_canvas.h dependencies have been removed, and replaced with skia-specific includes. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95083

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Patch Set 4 : Correct Windows build-breaks. #

Patch Set 5 : '' #

Patch Set 6 : '' #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -11 lines)			Patch
M	chrome/browser/ui/views/compact_nav/compact_location_bar_view.cc	View	1 2 3 4 5	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/plugin/webplugin_proxy.h	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	content/plugin/webplugin_proxy.cc	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	media/tools/scaler_bench/scaler_bench.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/gfx/canvas.h	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	ui/gfx/native_theme.h	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	ui/gfx/native_theme_win.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	views/controls/image_view.cc	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	webkit/glue/media/video_renderer_impl.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	webkit/plugins/ppapi/ppb_flash_impl_linux.cc	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	webkit/plugins/ppapi/webkit_forwarding_impl.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell_webthemecontrol.h	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	webkit/tools/test_shell/webview_host_gtk.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	webkit/tools/test_shell/webview_host_win.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

Jeff Timanus

Alok, PTAL. Owners: Not much to see here. Please rubber-stamp, as you see fit.

9 years, 5 months ago (2011-07-27 19:25:40 UTC) #1

alokp

On 2011/07/27 19:25:40, Jeff Timanus wrote: > Alok, PTAL. > > Owners: Not much to ...

9 years, 5 months ago (2011-07-27 19:42:21 UTC) #2

brettw

Alok has a good point, can you check the files and forward-declare when possible? http://codereview.chromium.org/7517020/diff/7001/content/plugin/webplugin_proxy.h ...

9 years, 5 months ago (2011-07-27 19:50:55 UTC) #3

Jeff Timanus

Thanks for the reviews. I double checked the includes, and I believe the only ones ...

9 years, 5 months ago (2011-07-27 20:04:06 UTC) #4

tony

webkit/glue and test_shell LGTM. You need jam@ or darin@ to sign off on webkit/plugins.

9 years, 5 months ago (2011-07-27 20:27:46 UTC) #5

darin (slow to review)

9 years, 5 months ago (2011-07-27 22:46:47 UTC) #9

LGTM

On Wed, Jul 27, 2011 at 3:25 PM, <sky@chromium.org> wrote:

> LGTM
>
>
http://codereview.chromium.**org/7517020/<http://codereview.chromium.org/7517...
>

Expand Messages | Collapse Messages