Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1747)

Unified Diff: chrome/browser/automation/automation_provider_observers.cc

Issue 7517019: Show crashed apps on NTP, desaturated. Click to reload. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/webui/extension_icon_source.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/automation/automation_provider_observers.cc
diff --git a/chrome/browser/automation/automation_provider_observers.cc b/chrome/browser/automation/automation_provider_observers.cc
index 155af6c78b7e40825ce1b50951ed4c5918996d7d..dd0cc47e7c28a4892814e76c45b4e5ce75c1e488 100644
--- a/chrome/browser/automation/automation_provider_observers.cc
+++ b/chrome/browser/automation/automation_provider_observers.cc
@@ -1981,8 +1981,10 @@ std::vector<DictionaryValue*>* GetAppInfoFromExtensions(
ext != extensions->end(); ++ext) {
// Only return information about extensions that are actually apps.
if ((*ext)->is_app()) {
- DictionaryValue* app_info = new DictionaryValue();
- AppLauncherHandler::CreateAppInfo(*ext, NULL, ext_service, app_info);
+ DictionaryValue* app_info =
+ AppLauncherHandler::CreateAppInfo(*ext, NULL, ext_service);
+ if (!app_info)
+ continue;
app_info->SetBoolean("is_component_extension",
(*ext)->location() == Extension::COMPONENT);
« no previous file with comments | « no previous file | chrome/browser/ui/webui/extension_icon_source.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698