Show crashed apps on NTP, desaturated. Click to reload.

chrome/browser/ui/webui/ntp/app_launcher_handler.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_WEBUI_NTP_APP_LAUNCHER_HANDLER_H_
 #define CHROME_BROWSER_UI_WEBUI_NTP_APP_LAUNCHER_HANDLER_H_
 #pragma once
 
 #include "base/memory/scoped_ptr.h"
 #include "chrome/browser/extensions/extension_app_api.h"
@@ skipping 23 matching lines @@
 // The handler for Javascript messages related to the "apps" view.
 class AppLauncherHandler : public WebUIMessageHandler,
                            public ExtensionUninstallDialog::Delegate,
                            public ExtensionInstallUI::Delegate,
                            public NotificationObserver {
  public:
   explicit AppLauncherHandler(ExtensionService* extension_service);
   virtual ~AppLauncherHandler();
 
   // Populate a dictionary with the information from an extension.
-  static void CreateAppInfo(const Extension* extension,
-                            const AppNotification* notification,
-                            ExtensionService* service,
-                            base::DictionaryValue* value);
+  static base::DictionaryValue* CreateAppInfo(
+      const Extension* extension,
+      const AppNotification* notification,
+      ExtensionService* service);
 
   // Callback for pings related to launching apps on the NTP.
   static bool HandlePing(Profile* profile, const std::string& path);
 
   // WebUIMessageHandler implementation.
-  virtual WebUIMessageHandler* Attach(WebUI* web_ui);
-  virtual void RegisterMessages();
+  virtual WebUIMessageHandler* Attach(WebUI* web_ui) OVERRIDE;
+  virtual void RegisterMessages() OVERRIDE;

[jstritar, 2011/07/28 15:05:26]

thanks for adding all these

 
   // NotificationObserver
   virtual void Observe(int type,
                       const NotificationSource& source,
-                      const NotificationDetails& details);
+                      const NotificationDetails& details) OVERRIDE;
 
   // Populate the given dictionary with all installed app info.
   void FillAppDictionary(base::DictionaryValue* value);
 
   // Create a dictionary value for the given extension. May return NULL, e.g. if
   // the given extension is not an app. If non-NULL, the caller assumes
   // ownership of the pointer.
   base::DictionaryValue* GetAppInfo(const Extension* extension);
 
   // Populate the given dictionary with the web store promo content.
@@ skipping 48 matching lines @@
   // Records an app launch in the corresponding |bucket| of the app launch
   // histogram if the |escaped_url| corresponds to an installed app.
   static void RecordAppLaunchByURL(Profile* profile,
                                    std::string escaped_url,
                                    extension_misc::AppLaunchBucket bucket);
 
   // Prompts the user to re-enable the app for |extension_id|.
   void PromptToEnableApp(const std::string& extension_id);
 
   // ExtensionUninstallDialog::Delegate:
-  virtual void ExtensionDialogAccepted();
-  virtual void ExtensionDialogCanceled();
+  virtual void ExtensionDialogAccepted() OVERRIDE;
+  virtual void ExtensionDialogCanceled() OVERRIDE;
 
   // ExtensionInstallUI::Delegate:
-  virtual void InstallUIProceed();
-  virtual void InstallUIAbort(bool user_initiated);
+  virtual void InstallUIProceed() OVERRIDE;
+  virtual void InstallUIAbort(bool user_initiated) OVERRIDE;
 
   // Returns the ExtensionUninstallDialog object for this class, creating it if
   // needed.
   ExtensionUninstallDialog* GetExtensionUninstallDialog();
 
   // Returns the ExtensionInstallUI object for this class, creating it if
   // needed.
   ExtensionInstallUI* GetExtensionInstallUI();
 
   // Helper that uninstalls all the default apps.
   void UninstallDefaultApps();
 
   // Continuation for installing a bookmark app after favicon lookup.
   void OnFaviconForApp(FaviconService::Handle handle,
                        history::FaviconData data);
 
   // The apps are represented in the extensions model, which
-  // outlives us since its owned by our containing profile.
-  ExtensionService* const extensions_service_;
+  // outlives us since it's owned by our containing profile.
+  ExtensionService* const extension_service_;

[jstritar, 2011/07/28 15:05:26]

nice cleanup

 
   // We monitor changes to the extension system so that we can reload the apps
   // when necessary.
   NotificationRegistrar registrar_;
 
   // Monitor extension preference changes so that the Web UI can be notified.
   PrefChangeRegistrar pref_change_registrar_;
 
   // Used to show confirmation UI for uninstalling extensions in incognito mode.
   scoped_ptr<ExtensionUninstallDialog> extension_uninstall_dialog_;
@@ skipping 11 matching lines @@
   // refreshing. This is useful when making many batch updates to avoid flicker.
   bool ignore_changes_;
 
   // Hold state for favicon requests.
   CancelableRequestConsumerTSimple<WebApplicationInfo*> favicon_consumer_;
 
   DISALLOW_COPY_AND_ASSIGN(AppLauncherHandler);
 };
 
 #endif  // CHROME_BROWSER_UI_WEBUI_NTP_APP_LAUNCHER_HANDLER_H_