Add prerender to ChromeOS.

Add prerender to ChromeOS.

This enables prerender whenever the active network is ethernet or wifi.

BUG=89966
TEST=Tested manually.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=94463

[cbentzel, 2011-07-27 17:23:33]

tburkard: Overall code.
ers: Make sure the ChromeOS portion is OK. Feel free to redirect to someone
else.

I initially wrote the ChromeOS network detection using the observer interfaces,
but it looked like the polling operations I am doing were cheap [and the number
of operations are also low]. Let me know if I need to go back to the observer
approach.

[dominich, 2011-07-27 17:27:43]

Are you missing prerender_condition.h?

http://codereview.chromium.org/7517016/diff/1/chrome/browser/chromeos/prerend...
File chrome/browser/chromeos/prerender_condition_network.h (right):

http://codereview.chromium.org/7517016/diff/1/chrome/browser/chromeos/prerend...
chrome/browser/chromeos/prerender_condition_network.h:20: virtual bool
CanPrerender() const;
OVERRIDE

[cbentzel, 2011-07-27 17:47:09]

Added prerender_condition.h

http://codereview.chromium.org/7517016/diff/1/chrome/browser/chromeos/prerend...
File chrome/browser/chromeos/prerender_condition_network.h (right):

http://codereview.chromium.org/7517016/diff/1/chrome/browser/chromeos/prerend...
chrome/browser/chromeos/prerender_condition_network.h:20: virtual bool
CanPrerender() const;
On 2011/07/27 17:27:43, dominich wrote:
> OVERRIDE

In this case it's a pure virtual function it's overriding so compiler would
check - but added this anyway.

[tburkard, 2011-07-27 19:52:53]

LGTM

Very nice interface.

You know that I'm generally not a huge fan of tiny files, so I'd put all this
into existing files, but that's just my opinion.

[Eric Shienbrood, 2011-07-27 22:06:33]

LGTM
for the Chrome OS part

http://codereview.chromium.org/7517016/diff/5001/chrome/browser/chromeos/prer...
File chrome/browser/chromeos/prerender_condition_network.cc (right):

http://codereview.chromium.org/7517016/diff/5001/chrome/browser/chromeos/prer...
chrome/browser/chromeos/prerender_condition_network.cc:28: }
I think you're right to keep things simple for now. But we'll probably want to
support prerendering for mobile data connections at some point, based on the
access technology in use (e.g., HSPA+ or LTE).

[cbentzel, 2011-07-28 13:00:32]

http://codereview.chromium.org/7517016/diff/5001/chrome/browser/chromeos/prer...
File chrome/browser/chromeos/prerender_condition_network.cc (right):

http://codereview.chromium.org/7517016/diff/5001/chrome/browser/chromeos/prer...
chrome/browser/chromeos/prerender_condition_network.cc:28: }
On 2011/07/27 22:06:33, Eric Shienbrood wrote:
> I think you're right to keep things simple for now. But we'll probably want to
> support prerendering for mobile data connections at some point, based on the
> access technology in use (e.g., HSPA+ or LTE).

The concern is more about usage caps at this point than performance.

[commit-bot: I haz the power, 2011-07-28 13:00:55]

Presubmit check for 7517016-5001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for: chrome/browser/profiles/profile_impl.cc

[cbentzel, 2011-07-28 13:17:08]

+mirandac for the change to ProfileImpl

[Miranda Callahan, 2011-07-28 14:14:30]

On 2011/07/28 13:17:08, cbentzel wrote:
> +mirandac for the change to ProfileImpl

ProfileImpl LGTM.

[commit-bot: I haz the power, 2011-07-28 15:30:22]

Change committed as 94463