Issue 7516001: InferRange simplifications

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7516001: InferRange simplifications (Closed)

Created:
9 years, 5 months ago by wingo

Modified:
9 years, 4 months ago

Reviewers:
fschneider, Kasper Lund

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

InferRange simplifications * src/hydrogen-instructions.cc (HConstant::InferRange) (HPhi::InferRange): Remove redundant setting of default values on range constructors. (HValue::AddNewRange): Remove dead code. ComputeInitialRange already asserts that we can HasRange(). BUG= TEST=tools/test.py --arch=x64 passes

Patch Set 1 #

Patch Set 2 : additional simplification to HValue::AddNewRange #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -6 lines)			Patch
	M	src/hydrogen-instructions.cc	View	1	3 chunks	+2 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

wingo

Modulo http://code.google.com/p/v8/issues/detail?id=1572, which exists for me on bleeding_edge, it passes the test.py.

9 years, 5 months ago (2011-07-26 17:50:34 UTC) #1

LGTM. I'll land.

Expand Messages | Collapse Messages