Issue 7516: - Optimized copying of FixedArray.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7516: - Optimized copying of FixedArray. (Closed)

Created:
12 years, 2 months ago by bak

Modified:
9 years, 7 months ago

Reviewers:
Kasper Lund

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

- Optimized copying of FixedArray. Committed: http://code.google.com/p/v8/source/detail?r=524

Patch Set 1 #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+64 lines, -33 lines)			Patch
M	src/heap.h	View	2 chunks	+8 lines, -2 lines	1 comment	Download
M	src/heap.cc	View	2 chunks	+47 lines, -12 lines	0 comments	Download
M	src/objects.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/objects.cc	View	2 chunks	+2 lines, -18 lines	0 comments	Download
M	src/objects-inl.h	View	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Kasper Lund

12 years, 2 months ago (2008-10-20 06:31:07 UTC) #2

LGTM. Nit:

http://codereview.chromium.org/7516/diff/1/6
File src/heap.h (right):

http://codereview.chromium.org/7516/diff/1/6#newcode821
Line 821: // Allocate unitialized fixed array (pretenure == NON_TENURE).
Why not write the comment as: Allocate uninitialized, non-tenured fixed array?

Expand Messages | Collapse Messages